4:38 a.m.
Lei Li has uploaded a new change for review.
Change subject: Make API.py conform to pep8
......................................................................
Make API.py conform to pep8
Change-Id: I9549186e537ba23994891e27b58be3d6d3770f40
Signed-off-by: Lei Li <lilei(a)linux.vnet.ibm.com>
---
M vdsm/API.py
1 file changed, 89 insertions(+), 38 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/3561/1
--
To view, visit http://gerrit.ovirt.org/3561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9549186e537ba23994891e27b58be3d6d3770f40
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com>
1:15 p.m.
Lei Li has posted comments on this change.
Change subject: Make API.py conform to pep8
......................................................................
Patch Set 5:
Resubmit with code rebased.
--
To view, visit http://gerrit.ovirt.org/3561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9549186e537ba23994891e27b58be3d6d3770f40
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12:32 p.m.
Igor Lvovsky has posted comments on this change.
Change subject: Make API.py conform to pep8
......................................................................
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9549186e537ba23994891e27b58be3d6d3770f40
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12:24 p.m.
Igor Lvovsky has posted comments on this change.
Change subject: Make API.py conform to pep8
......................................................................
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/3561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9549186e537ba23994891e27b58be3d6d3770f40
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
1:25 p.m.
Igor Lvovsky has submitted this change and it was merged.
Change subject: Make API.py conform to pep8
......................................................................
Make API.py conform to pep8
v1->v2
- Modify all the place to follow the rule that break around
a binary operator after the operator, and other small errors
suggested by Saggi.
Change-Id: I9549186e537ba23994891e27b58be3d6d3770f40
Signed-off-by: Lei Li <lilei(a)linux.vnet.ibm.com>
---
M AUTHORS
M Makefile.am
M vdsm/API.py
3 files changed, 92 insertions(+), 38 deletions(-)
Approvals:
Igor Lvovsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9549186e537ba23994891e27b58be3d6d3770f40
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
1:25 p.m.
Igor Lvovsky has posted comments on this change.
Change subject: Make API.py conform to pep8
......................................................................
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9549186e537ba23994891e27b58be3d6d3770f40
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
10:42 a.m.
Saggi Mizrahi has posted comments on this change.
Change subject: Make API.py conform to pep8
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9549186e537ba23994891e27b58be3d6d3770f40
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:59 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Make API.py conform to pep8
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File vdsm/API.py
Line 1117: logging.getLogger('clientIF.setLogLevel').info('Setting
loglevel' + \
note that within parenthesis, backslash is not really required or helpful.
--
To view, visit http://gerrit.ovirt.org/3561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9549186e537ba23994891e27b58be3d6d3770f40
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
8:28 p.m.
Lei Li has posted comments on this change.
Change subject: Make API.py conform to pep8
......................................................................
--
To view, visit http://gerrit.ovirt.org/3561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9549186e537ba23994891e27b58be3d6d3770f40
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Sheldon Feng <shaohef(a)linux.vnet.ibm.com>
3:56 p.m.
Saggi Mizrahi has posted comments on this change.
Change subject: Make API.py conform to pep8
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(4 inline comments)
I only commented on errors once or twice but they are spread throughout
....................................................
File vdsm/API.py
Line 233: % vmParams['vmId'])
http://www.python.org/dev/peps/pep-0008/#id14
"The preferred place to break around a binary operator is after the operator, not
before it."
Line 244: % (vmParams['vmId'],
len(self._cif.vmContainer)))
again
Line 372: vmId, nic'}}
I think you meant
.... parameters: ' + \
'vmId...
Line 388: vmId, nic'}}
again
--
To view, visit http://gerrit.ovirt.org/3561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9549186e537ba23994891e27b58be3d6d3770f40
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Sheldon Feng <shaohef(a)linux.vnet.ibm.com>
9:38 a.m.
Sheldon Feng has posted comments on this change.
Change subject: Make API.py conform to pep8
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/API.py
Line 370: return {'status': {'code':
errCode['MissParam']['status']['code'],
you can check line 169, 176, 180, 186, 211, 218, they are same, the dictionary errCode
are divided into 2 lines.
and line 370, 386, 402, 418, they are same, the dictionary errCode are in one line.
--
To view, visit http://gerrit.ovirt.org/3561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9549186e537ba23994891e27b58be3d6d3770f40
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Sheldon Feng <shaohef(a)linux.vnet.ibm.com>
6:31 a.m.
Lei Li has posted comments on this change.
Change subject: Make API.py conform to pep8
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/API.py
Line 370: return {'status': {'code':
errCode['MissParam']['status']['code'],
What do you mean the former code?
I did not modify this line, and I believe it's the same as before. :)
--
To view, visit http://gerrit.ovirt.org/3561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9549186e537ba23994891e27b58be3d6d3770f40
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Sheldon Feng <shaohef(a)linux.vnet.ibm.com>
5:53 a.m.
Sheldon Feng has posted comments on this change.
Change subject: Make API.py conform to pep8
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/API.py
Line 370: return {'status': {'code':
errCode['MissParam']['status']['code'],
the former style is "
errCode['MissParam']
['status']['code'],
"
I prefer the same code style with same former code.
--
To view, visit http://gerrit.ovirt.org/3561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9549186e537ba23994891e27b58be3d6d3770f40
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Sheldon Feng <shaohef(a)linux.vnet.ibm.com>
4441
days inactive
4448
days old
vdsm-patches@lists.fedorahosted.org
12 comments
5 participants
participants (5)
-
Dan Kenigsberg -
Igor Lvovsky -
lilei＠linux.vnet.ibm.com -
shaohef＠linux.vnet.ibm.com -
smizrahi＠redhat.com