Change in vdsm[master]: Use the full prefix when removing file images.

Eduardo has uploaded a new change for review.

Change subject: Use the full prefix when removing file images.
......................................................................

Use the full prefix when removing file images.

os.tempnam() prefix is limited to 5 characters.

Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1005788

Change-Id: Ie42dfb17eff1cbbf054de0cab493321567ea7e25
Signed-off-by: Eduardo 
---
M vdsm/storage/fileSD.py
1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/19107/1

diff --git a/vdsm/storage/fileSD.py b/vdsm/storage/fileSD.py
index ee1255f..0cccaef 100644
--- a/vdsm/storage/fileSD.py
+++ b/vdsm/storage/fileSD.py
@@ -342,7 +342,9 @@
     def deleteImage(self, sdUUID, imgUUID, volsImgs):
         currImgDir = getImagePath(sdUUID, imgUUID)
         dirName, baseName = os.path.split(currImgDir)
-        toDelDir = os.tempnam(dirName, sd.REMOVED_IMAGE_PREFIX + baseName)
+        saltDir, salt = os.path.split(os.tempnam(dirName, "_DEL_"))
+        toDelDir = os.path.join(saltDir,
+                                sd.REMOVED_IMAGE_PREFIX + baseName + salt)
         try:
             self.oop.os.rename(currImgDir, toDelDir)
         except OSError as e:

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Use the full prefix when removing file images.
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4355/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3458/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4274/ : SUCCESS

Ayal Baron has posted comments on this change.

Change subject: Use the full prefix when removing file images.
......................................................................

Patch Set 1: Code-Review+2

Sergey Gotliv has posted comments on this change.

Change subject: Use the full prefix when removing file images.
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

The patch is good, but descriptions should be changed?

....................................................
Commit Message
Line 7: Use the full prefix when removing file images.
Line 8: 
Line 9: os.tempnam() prefix is limited to 5 characters.
Line 10: 
Line 11: Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1005788
Bug marked as a private bug, so I assume you need to remove this link.
Line 12: 
Line 13: Change-Id: Ie42dfb17eff1cbbf054de0cab493321567ea7e25

Itamar Heim has posted comments on this change.

Change subject: Use the full prefix when removing file images.
......................................................................

Patch Set 1:

ping

Itamar Heim has abandoned this change.

Change subject: Use the full prefix when removing file images.
......................................................................

Abandoned

abandoning per no reply. please restore if still relevant.