Change in vdsm[ovirt-3.2]: schema: Fix schema for VM.updateDevice

Hello Adam Litke, Saggi Mizrahi,

I'd like you to do a code review.  Please visit

http://gerrit.ovirt.org/10019

to review the following change.

Change subject: schema: Fix schema for VM.updateDevice
......................................................................

schema: Fix schema for VM.updateDevice

Another recent update broke the schema file.  I'll take the blame for this one
since I approved the change :)  Some missing and/or malformed data in comments
was causing the process-schema script to fail.  Another reason for validating
the schema during the build.

Change-Id: If88596050ace9511bcc7be65ee46645359e30532
Signed-off-by: Adam Litke 
Reviewed-on: http://gerrit.ovirt.org/10012
Reviewed-by: Saggi Mizrahi 
Tested-by: Saggi Mizrahi 
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 5 insertions(+), 4 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/19/10019/1

diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index 9772e18..487e69a 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -4894,10 +4894,12 @@
 ##
 # @vmUpdateDeviceParams:
 #
+# A discriminated record of update parameters for a VM device.
+#
 # @deviceType: The VM device type to update. For example 'interface' for
 #              network devices or 'disk' for disk storage devices.
 #
-# Since 4.10.3
+# Since: 4.10.3
 ##
 {'type': 'vmUpdateDeviceParams',
  'data': {'deviceType': 'VmDeviceType'},
@@ -4924,11 +4926,11 @@
 #                 by alias. If omitted, it keeps the current mirroring
 #                 configuration.
 #
-# Since 4.10.3
+# Since: 4.10.3
 ##
 {'type': 'vmUpdateInterfaceDeviceParams',
  'data': {'*network': 'str', '*linkActive': 'bool',
-          'alias': 'str', '*portMirroring': '[str]'}}
+          'alias': 'str', '*portMirroring': ['str']}}

##
 # @VM.updateDevice:
@@ -4943,7 +4945,6 @@
 # The VM definition, as updated
 #
 # Since: 4.10.3
-#
 ##
 {'command': {'class': 'VM', 'name': 'updateDevice'},
  'data': {'vmId': 'UUID', 'params': 'vmUpdateDeviceParams'},

--
To view, visit http://gerrit.ovirt.org/10019
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If88596050ace9511bcc7be65ee46645359e30532
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.2
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Saggi Mizrahi

Adam Litke has posted comments on this change.

Change subject: schema: Fix schema for VM.updateDevice
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/10019
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If88596050ace9511bcc7be65ee46645359e30532
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.2
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: schema: Fix schema for VM.updateDevice
......................................................................

Patch Set 1: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/10019
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If88596050ace9511bcc7be65ee46645359e30532
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.2
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

Antoni Segura Puimedon has posted comments on this change.

Change subject: schema: Fix schema for VM.updateDevice
......................................................................

Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/10019
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If88596050ace9511bcc7be65ee46645359e30532
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.2
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

[Federico Simoncelli]

Federico Simoncelli has submitted this change and it was merged.

Change subject: schema: Fix schema for VM.updateDevice
......................................................................

schema: Fix schema for VM.updateDevice

Another recent update broke the schema file.  I'll take the blame for this one
since I approved the change :)  Some missing and/or malformed data in comments
was causing the process-schema script to fail.  Another reason for validating
the schema during the build.

Change-Id: If88596050ace9511bcc7be65ee46645359e30532
Signed-off-by: Adam Litke 
Reviewed-on: http://gerrit.ovirt.org/10012
Reviewed-by: Saggi Mizrahi 
Tested-by: Saggi Mizrahi 
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 5 insertions(+), 4 deletions(-)

Approvals:
  Adam Litke: Looks good to me, but someone else must approve
  Antoni Segura Puimedon: Verified
  Federico Simoncelli: 
  Dan Kenigsberg: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/10019
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If88596050ace9511bcc7be65ee46645359e30532
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.2
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi