Change in vdsm[master]: enable attaching non-vlan network to vlanable network.

Shahar Havivi has uploaded a new change for review.

Change subject: enable attaching non-vlan network to vlanable network.
......................................................................

enable attaching non-vlan network to vlanable network.

this patch have a security breach:
when adding a network without a vlan to already attach vlan network this
network can monitor all the traffic of the other vlans.

we may be able to restrict it using ebtables.

Change-Id: Icb96ead734cb1394ff00a99bf7f62b77ad15f1d6
---
M vdsm/configNetwork.py
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/2161/1
--
To view, visit http://gerrit.ovirt.org/2161
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb96ead734cb1394ff00a99bf7f62b77ad15f1d6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;

Shahar Havivi has posted comments on this change.

Change subject: enable attaching non-vlan network to vlanable network.
......................................................................


Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/2161
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb96ead734cb1394ff00a99bf7f62b77ad15f1d6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com&gt;

Shahar Havivi has abandoned this change.

Change subject: enable attaching non-vlan network to vlanable network.
......................................................................


Patch Set 1: Abandoned

--
To view, visit http://gerrit.ovirt.org/2161
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Icb96ead734cb1394ff00a99bf7f62b77ad15f1d6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com&gt;

Shahar Havivi has restored this change.

Change subject: enable attaching non-vlan network to vlanable network.
......................................................................


Patch Set 1: Restored

--
To view, visit http://gerrit.ovirt.org/2161
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: Icb96ead734cb1394ff00a99bf7f62b77ad15f1d6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com&gt;

Shahar Havivi has abandoned this change.

Change subject: enable attaching non-vlan network to vlanable network.
......................................................................


Patch Set 1: Abandoned

--
To view, visit http://gerrit.ovirt.org/2161
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Icb96ead734cb1394ff00a99bf7f62b77ad15f1d6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: enable attaching non-vlan network to vlanable network.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

actually, we do not want to allow a bridged network on top of a nic with vlan'ed
networks.

Please abandon this patch.

--
To view, visit http://gerrit.ovirt.org/2161
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb96ead734cb1394ff00a99bf7f62b77ad15f1d6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com&gt;