From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: network: use provide __repr__ and __str__ by route and rule
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/77415/2//COMMIT_MSG
Commit Message:
Line 6:
Line 7: network: use provide __repr__ and __str__ by route and rule
Line 8:
Line 9: IPRuleData and IPRouteData now provides __str__ and __repr__
Line 10: methods in a more Pythonic way.
I don't see the benefit of defining both functions; your __str__ is not much more
human readable, so how about defining only __repr__?
Line 11:
Line 12: Change-Id: I68bed024a52e8f0de9369be0b2f6b2d0153165b1
--
To view, visit
https://gerrit.ovirt.org/77415
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68bed024a52e8f0de9369be0b2f6b2d0153165b1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes