Federico Simoncelli has uploaded a new change for review.
Change subject: BZ#752470 Related: Don't use SIGTERM in spmprotect.sh ......................................................................
BZ#752470 Related: Don't use SIGTERM in spmprotect.sh
Attempting to stop the SPM (SIGUSR1) and using SIGKILL if that fails is already enough. In any case giving vdsm only 2 seconds between SIGTERM and SIGKILL was a too short timeout to hope in a restart.
Change-Id: I83e07f966b69e2f8ba803f0d2a5020d90e6029d8 --- M vdsm/storage/protect/spmprotect.sh 1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/265/1 -- To view, visit http://gerrit.ovirt.org/265 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I83e07f966b69e2f8ba803f0d2a5020d90e6029d8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#752470 Related: Don't use SIGTERM in spmprotect.sh ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
.................................................... File vdsm/storage/protect/spmprotect.sh Line 77: log "Trying to stop vdsm for spUUID=$spUUID id=$ID lease_path=$LEASE_FILE" maybe it is only because I wrote the lines you are deleting, but why is this change related to 752470 ?
-- To view, visit http://gerrit.ovirt.org/265 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I83e07f966b69e2f8ba803f0d2a5020d90e6029d8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: BZ#752470 Related: Don't use SIGTERM in spmprotect.sh ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/265 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I83e07f966b69e2f8ba803f0d2a5020d90e6029d8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Itamar Heim has posted comments on this change.
Change subject: BZ#752470 Related: Don't use SIGTERM in spmprotect.sh ......................................................................
Patch Set 1:
ping?
Itamar Heim has abandoned this change.
Change subject: BZ#752470 Related: Don't use SIGTERM in spmprotect.sh ......................................................................
Abandoned
no reply - abandoning - please restore if still relevant
vdsm-patches@lists.fedorahosted.org