From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: JsonRpcClient supports multiple subscriptions
......................................................................
Patch Set 31: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/78656/31/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 595: Set a callback which handles messages received
Line 596: from the main RPC queue.
Line 597:
Line 598: :param handler: Callback to handle incoming messages
Line 599: :type handler: function (string) -> ()
so again, what this notion means? sorry for my ignorance.
what function this handler should have? handle_message? lets make interface for that if
needed
Line 600: """
Line 601: self._message_handler = handler
Line 602:
Line 603: def send(self, data, destination=None):
--
To view, visit
https://gerrit.ovirt.org/78656
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f5df1a5208281241be82f9e651788eca520be64
Gerrit-PatchSet: 31
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes