Change in vdsm[master]: Makefile.am: create vdsm logs on make install

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has uploaded a new change for review.

Change subject: Makefile.am: create vdsm logs on make install
......................................................................

Makefile.am: create vdsm logs on make install

Currently during the RPM install vdsm creates the below logs files:
/var/log/vdsm/{metadata.log,mom.log,supervdsm.log,vdsm.log}
and we should do the same for non rpm distro.

Change-Id: I7f5dc4ca01fecddc5226255e37b0bab68b8c479f
Signed-off-by: Douglas Schilling Landgraf 
---
M vdsm/Makefile.am
1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/23882/1

diff --git a/vdsm/Makefile.am b/vdsm/Makefile.am
index 66b9af5..5e7f2cf 100644
--- a/vdsm/Makefile.am
+++ b/vdsm/Makefile.am
@@ -167,6 +167,10 @@
    $(MKDIR_P) $(DESTDIR)$(vdsmlibdir)/upgrade
    $(MKDIR_P) $(DESTDIR)$(vdsmbackupdir)
    $(MKDIR_P) $(DESTDIR)$(localstatedir)/lib/libvirt/qemu/channels
+	touch $(DESTDIR)$(vdsmlogdir)/{metadata.log,mom.log,supervdsm.log,vdsm.log}
+	chmod 0644 $(DESTDIR)$(vdsmlogdir)/{metadata.log,mom.log,supervdsm.log,vdsm.log}
+	chown $(VDSMUSER):$(VDSMGROUP) $(DESTDIR)$(vdsmlogdir)/{metadata.log,mom.log,vdsm.log}
+	chown root:root $(DESTDIR)$(vdsmlogdir)/supervdsm.log

uninstall-local: \
    	uninstall-data-dhclient-hooks \

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Makefile.am: create vdsm logs on make install
......................................................................

Patch Set 1: Verified+1

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Makefile.am: create vdsm logs on make install
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6113/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7006/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6900/ : SUCCESS

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Makefile.am: create vdsm logs on make install
......................................................................

Patch Set 1:

ping?

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Makefile.am: create vdsm logs on make install
......................................................................

Patch Set 1: Code-Review-1

(1 comment)

you should also remove the relevant lines from the spec's %install section.

http://gerrit.ovirt.org/#/c/23882/1/vdsm/Makefile.am
File vdsm/Makefile.am:

Line 166: 	$(MKDIR_P) $(DESTDIR)$(vdsmlibdir)/persistence
Line 167: 	$(MKDIR_P) $(DESTDIR)$(vdsmlibdir)/upgrade
Line 168: 	$(MKDIR_P) $(DESTDIR)$(vdsmbackupdir)
Line 169: 	$(MKDIR_P) $(DESTDIR)$(localstatedir)/lib/libvirt/qemu/channels
Line 170: 	touch $(DESTDIR)$(vdsmlogdir)/{metadata.log,mom.log,supervdsm.log,vdsm.log}
It would be nicer to define a macro, rather than repeat the file names 3 times.
Line 171: 	chmod 0644 $(DESTDIR)$(vdsmlogdir)/{metadata.log,mom.log,supervdsm.log,vdsm.log}
Line 172: 	chown $(VDSMUSER):$(VDSMGROUP) $(DESTDIR)$(vdsmlogdir)/{metadata.log,mom.log,vdsm.log}
Line 173: 	chown root:root $(DESTDIR)$(vdsmlogdir)/supervdsm.log
Line 174:

Itamar Heim has posted comments on this change.

Change subject: Makefile.am: create vdsm logs on make install
......................................................................

Patch Set 1:

ping

Itamar Heim has abandoned this change.

Change subject: Makefile.am: create vdsm logs on make install
......................................................................

Abandoned

no activity. please restore if relevant.