Change in vdsm[master]: Add the the debug plugin client

[Federico Simoncelli]

Federico Simoncelli has uploaded a new change for review.

Change subject: Add the the debug plugin client
......................................................................

Add the the debug plugin client

Signed-off-by: Federico Simoncelli 
Change-Id: Ifbbe131bf726951abc5ce2f75d27315a93c7593d
---
M vdsm.spec.in
M vdsm/Makefile.am
A vdsm/debugPluginClient.py
3 files changed, 38 insertions(+), 4 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/3428/1
--
To view, visit http://gerrit.ovirt.org/3428
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifbbe131bf726951abc5ce2f75d27315a93c7593d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Add the the debug plugin client
......................................................................

Patch Set 1: (1 inline comment)

....................................................
File vdsm/Makefile.am
Line 26: 	API.py \
Just sorting

--
To view, visit http://gerrit.ovirt.org/3428
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbbe131bf726951abc5ce2f75d27315a93c7593d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Add the the debug plugin client
......................................................................

Patch Set 1: Verified; Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3428
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbbe131bf726951abc5ce2f75d27315a93c7593d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

Saggi Mizrahi has posted comments on this change.

Change subject: Add the the debug plugin client
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3428
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbbe131bf726951abc5ce2f75d27315a93c7593d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

[Xu He Jie]

Xu He Jie has posted comments on this change.

Change subject: Add the the debug plugin client
......................................................................

Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/3428
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbbe131bf726951abc5ce2f75d27315a93c7593d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Xu He Jie

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Add the the debug plugin client
......................................................................

Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

Let's add this simple module to pep8 whitelist!

....................................................
File vdsm/debugPluginClient.py
Line 38:             i += 1
would you like to considers tabs, too?

--
To view, visit http://gerrit.ovirt.org/3428
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbbe131bf726951abc5ce2f75d27315a93c7593d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Xu He Jie

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Add the the debug plugin client
......................................................................

Patch Set 3: Verified; Looks good to me, approved

(1 inline comment)

....................................................
File vdsm/debugPluginClient.py
Line 41:             i += 1
this is not going to work for code that mixes tabs and spaces.
but who cares about such code? it is not pep8 complient ;-)

--
To view, visit http://gerrit.ovirt.org/3428
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbbe131bf726951abc5ce2f75d27315a93c7593d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Xu He Jie

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Add the the debug plugin client
......................................................................

Add the the debug plugin client

Signed-off-by: Federico Simoncelli 
Change-Id: Ifbbe131bf726951abc5ce2f75d27315a93c7593d
---
M Makefile.am
M vdsm.spec.in
M vdsm/Makefile.am
A vdsm/debugPluginClient.py
4 files changed, 63 insertions(+), 6 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3428
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbbe131bf726951abc5ce2f75d27315a93c7593d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Xu He Jie