Change in vdsm[ovirt-3.4]: Fix defaultRoute handling

[Dan Kenigsberg]

Hello Antoni Segura Puimedon, Assaf Muller,

I'd like you to do a code review.  Please visit

http://gerrit.ovirt.org/24677

to review the following change.

Change subject: Fix defaultRoute handling
......................................................................

Fix defaultRoute handling

defaultRoute wasn't being past correctly to objectivizeNetwork,
so that defaultRoute was always None inside the function,
no matter what was past to it.

This meant that DEFROUTE=yes/no was never written to ifcfg files,
and 'ip route add default...' never applied by the iproute2
configurator.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1015009

Change-Id: I643c5fe9dab39833d73541b7a1bfaae9ae3e749d
Signed-off-by: Assaf Muller 
Reviewed-on: http://gerrit.ovirt.org/24631
Reviewed-by: Antoni Segura Puimedon 
Reviewed-by: Dan Kenigsberg 
Tested-by: Dan Kenigsberg 
---
M vdsm/configNetwork.py
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/24677/1

diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py
index 2be811c..78b5012 100755
--- a/vdsm/configNetwork.py
+++ b/vdsm/configNetwork.py
@@ -279,7 +279,7 @@
     netEnt = objectivizeNetwork(network if bridged else None, vlan, bonding,
                                 bondingOptions, nics, mtu, ipaddr, netmask,
                                 gateway, bootproto, ipv6addr, ipv6gateway,
-                                defaultRoute, _netinfo=_netinfo,
+                                defaultRoute=defaultRoute, _netinfo=_netinfo,
                                 configurator=configurator, **options)

netEnt.configure(**options)

Assaf Muller has posted comments on this change.

Change subject: Fix defaultRoute handling
......................................................................

Patch Set 1: Verified+1

Assaf Muller has posted comments on this change.

Change subject: Fix defaultRoute handling
......................................................................

Patch Set 1: Code-Review+1

Yaniv Bronhaim has posted comments on this change.

Change subject: Fix defaultRoute handling
......................................................................

Patch Set 1: Code-Review+2

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: Fix defaultRoute handling
......................................................................

Fix defaultRoute handling

defaultRoute wasn't being past correctly to objectivizeNetwork,
so that defaultRoute was always None inside the function,
no matter what was past to it.

This meant that DEFROUTE=yes/no was never written to ifcfg files,
and 'ip route add default...' never applied by the iproute2
configurator.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1015009

Change-Id: I643c5fe9dab39833d73541b7a1bfaae9ae3e749d
Signed-off-by: Assaf Muller 
Reviewed-on: http://gerrit.ovirt.org/24631
Reviewed-by: Antoni Segura Puimedon 
Reviewed-by: Dan Kenigsberg 
Tested-by: Dan Kenigsberg 
Reviewed-on: http://gerrit.ovirt.org/24677
Reviewed-by: Yaniv Bronhaim 
---
M vdsm/configNetwork.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, approved
  Assaf Muller: Verified; Looks good to me, but someone else must approve