Change in vdsm[master]: Integrate new mounting code to blockSD

Saggi Mizrahi has uploaded a new change for review.

Change subject: Integrate new mounting code to blockSD
......................................................................

Integrate new mounting code to blockSD

Change-Id: I14bf200a53331e23b65d77732c8ecd663f5772ec
---
M vdsm/storage/blockSD.py
1 file changed, 13 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/546/1
--
To view, visit http://gerrit.ovirt.org/546
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I14bf200a53331e23b65d77732c8ecd663f5772ec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Saggi Mizrahi has abandoned this change.

Change subject: Integrate new mounting code to blockSD
......................................................................


Patch Set 1: Abandoned

Merged to http://gerrit.ovirt.org/543

--
To view, visit http://gerrit.ovirt.org/546
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I14bf200a53331e23b65d77732c8ecd663f5772ec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Integrate new mounting code to blockSD
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/storage/blockSD.py
Line 845:             masterMount.mount(vfstype="ext3")
why not use fileUtils.FSTYPE_EXT3 ?

Line 863:         masterMount = self._getMasterMount()
huh? assignment with no usage?

--
To view, visit http://gerrit.ovirt.org/546
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I14bf200a53331e23b65d77732c8ecd663f5772ec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;