Change in vdsm[master]: Get oop from object instance

Shu Ming has uploaded a new change for review.

Change subject: Get oop from object instance
......................................................................

Get oop from object instance

In FileStorageDomain non-class method, self.oop should
be used instead of oop

Change-Id: Ia6b86f2c5e382774003772837e32bd62f8ad29ce
Signed-off-by: Shu Ming 
---
M vdsm/storage/fileSD.py
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/20/8920/1

diff --git a/vdsm/storage/fileSD.py b/vdsm/storage/fileSD.py
index f92ed98..7d6e1ab 100644
--- a/vdsm/storage/fileSD.py
+++ b/vdsm/storage/fileSD.py
@@ -177,7 +177,7 @@

def getReadDelay(self):
         t = time.time()
-        oop.getProcessPool(self.sdUUID).directReadLines(self.metafile)
+        self.oop.getProcessPool(self.sdUUID).directReadLines(self.metafile)
         return time.time() - t

def getFileList(self, pattern, caseSensitive):

--
To view, visit http://gerrit.ovirt.org/8920
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6b86f2c5e382774003772837e32bd62f8ad29ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming

Zhou Zheng Sheng has posted comments on this change.

Change subject: Get oop from object instance
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/fileSD.py
Line 176:                   })
Line 177: 
Line 178:     def getReadDelay(self):
Line 179:         t = time.time()
Line 180:         self.oop.getProcessPool(self.sdUUID).directReadLines(self.metafile)
After reading the code implementing StorageDomain.oop, I think this line should be

self.oop.directReadLines(self.metafile)
Line 181:         return time.time() - t
Line 182: 
Line 183:     def getFileList(self, pattern, caseSensitive):
Line 184:         """

--
To view, visit http://gerrit.ovirt.org/8920
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6b86f2c5e382774003772837e32bd62f8ad29ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming 
Gerrit-Reviewer: Zhou Zheng Sheng

Zhou Zheng Sheng has posted comments on this change.

Change subject: Get oop from object instance
......................................................................

Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8920
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6b86f2c5e382774003772837e32bd62f8ad29ce
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Zhou Zheng Sheng

ShaoHe Feng has posted comments on this change.

Change subject: Get oop from object instance
......................................................................

Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8920
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6b86f2c5e382774003772837e32bd62f8ad29ce
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Zhou Zheng Sheng

Saggi Mizrahi has posted comments on this change.

Change subject: Get oop from object instance
......................................................................

Patch Set 2: Code-Review+2

Mark Wu has posted comments on this change.

Change subject: Get oop from object instance
......................................................................

Patch Set 2: Code-Review-1

Ming,  it seems that this patch is not needed any more because getReadDelay() was re-implemented totally. So you could abandon it.

Itamar Heim has posted comments on this change.

Change subject: Get oop from object instance
......................................................................

Patch Set 2:

ping?

Zhou Zheng Sheng has posted comments on this change.

Change subject: Get oop from object instance
......................................................................

Patch Set 2: -Code-Review

Looks like it should be abandoned according to Mark Wu's last comments.

Shu Ming has abandoned this change.

Change subject: Get oop from object instance
......................................................................

Abandoned

See Mark's comment