Change in vdsm[master]: Split xmlrpc server into its own rpm

Adam Litke has uploaded a new change for review.

Change subject: Split xmlrpc server into its own rpm
......................................................................

Split xmlrpc server into its own rpm

We would like to move towards a model where API bindings are optional.  This
means that we can package each one separately any any combination of bindings
can be enabled/disabled by editing the vdsm configuration file.  This patch
splits the XMLRPC binding into a new package (vdsm-xmlrpc) and modifies the
binding loading logic in clientIF to check the configuration file and handle
import errors that can result if a user enables the binding but does not install
the rpm.

Change-Id: Ifdf84af0b903406c148877e26ec27e6ed913bd51
Signed-off-by: Adam Litke 
---
M vdsm.spec.in
M vdsm/clientIF.py
2 files changed, 29 insertions(+), 4 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/3892/1
--
To view, visit http://gerrit.ovirt.org/3892
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifdf84af0b903406c148877e26ec27e6ed913bd51
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke

Adam Litke has posted comments on this change.

Change subject: Split xmlrpc server into its own rpm
......................................................................

Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/3892
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdf84af0b903406c148877e26ec27e6ed913bd51
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg

Mark Wu has posted comments on this change.

Change subject: Split xmlrpc server into its own rpm
......................................................................

Patch Set 1: (1 inline comment)

....................................................
File vdsm/clientIF.py
Line 118: 
It could be better if we implement it as the following way:
1. add a configuration value to tell vdsm which bindings to be enables, like:
   ('bindings', 'XMLRPC, REST', 'bindings to be enabled')
2. move the parameters into their individual module if they can't be shared.
3. parse the configured value of 'bindings', and import the module "'Binding' + item" . it requires the binding module is stored in the same path.

It's the same as  what you did in MOM. It could make code more clean.  Does it make sense?

--
To view, visit http://gerrit.ovirt.org/3892
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdf84af0b903406c148877e26ec27e6ed913bd51
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Mark Wu

Saggi Mizrahi has posted comments on this change.

Change subject: Split xmlrpc server into its own rpm
......................................................................

Patch Set 2: Looks good to me, but someone else must approve

Looks good, I suggest getting a verify from someone on a clean machine before pushing this though.

--
To view, visit http://gerrit.ovirt.org/3892
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdf84af0b903406c148877e26ec27e6ed913bd51
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Saggi Mizrahi

Adam Litke has posted comments on this change.

Change subject: Split xmlrpc server into its own rpm
......................................................................

Patch Set 2: Verified

As Saggi suggested, I verified this on a clean install of Fedora 17.  Vdsm runs fine with and without xmlrpc installed.

--
To view, visit http://gerrit.ovirt.org/3892
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdf84af0b903406c148877e26ec27e6ed913bd51
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Split xmlrpc server into its own rpm
......................................................................

Patch Set 5: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3892
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdf84af0b903406c148877e26ec27e6ed913bd51
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Saggi Mizrahi

Adam Litke has posted comments on this change.

Change subject: Split xmlrpc server into its own rpm
......................................................................

Patch Set 5: Verified

--
To view, visit http://gerrit.ovirt.org/3892
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdf84af0b903406c148877e26ec27e6ed913bd51
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Split xmlrpc server into its own rpm
......................................................................

Split xmlrpc server into its own rpm

We would like to move towards a model where API bindings are optional.  This
means that we can package each one separately any any combination of bindings
can be enabled/disabled by editing the vdsm configuration file.  This patch
splits the XMLRPC binding into a new package (vdsm-xmlrpc) and modifies the
binding loading logic in clientIF to check the configuration file and handle
import errors that can result if a user enables the binding but does not install
the rpm.

Change-Id: Ifdf84af0b903406c148877e26ec27e6ed913bd51
Signed-off-by: Adam Litke 
---
M vdsm.spec.in
M vdsm/clientIF.py
2 files changed, 29 insertions(+), 4 deletions(-)

Approvals:
  Adam Litke: Verified
  Dan Kenigsberg: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3892
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifdf84af0b903406c148877e26ec27e6ed913bd51
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Saggi Mizrahi