Martin Sivák has posted comments on this change.
Change subject: xmlrpc: marshalling of Long type
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/34856/1/vdsm/rpc/BindingXMLRPC.py
File vdsm/rpc/BindingXMLRPC.py:
Line 41: _glusterEnabled = True
Line 42: except ImportError:
Line 43: _glusterEnabled = False
Line 44:
Line 45: value = "<value><string>%s</string></value>\n"
I would probably use _STRING_VALUE or something like that
Line 46:
Line 47:
Line 48: class BindingXMLRPC(object):
Line 49: def __init__(self, cif, log, port):
Line 1040: (self.merge, 'merge'),
Line 1041: (self.vmUpdateVmPolicy, 'updateVmPolicy'),
Line 1042: (self.vmSetIoTune, 'setIoTune'),
Line 1043: (self.vmGetIoTunePolicy, 'getIoTunePolicy'),
Line 1044: (self.floatTest, 'floatTest'))
This does seem to be a leftover from development..
Line 1045:
Line 1046: def getIrsMethods(self):
Line 1047: return ((self.domainActivate, 'activateStorageDomain'),
Line 1048: (self.domainAttach, 'attachStorageDomain'),
--
To view, visit
http://gerrit.ovirt.org/34856
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I56341566e4add6a093ba89eb81e09ee9e7a631b1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes