[NEW PATCH] vdsm-logrotate: remove leftovers of coredump handling (via gerrit-bot)

[Dan Kenigsberg]

New patch submitted by Dan Kenigsberg (danken(a)redhat.com)

You can review this change at: http://gerrit.usersys.redhat.com/741

commit 702a103ba4c09000b6971db3533069f55739b3e4
Author: Dan Kenigsberg <danken(a)redhat.com&gt;
Date:   Sun Jul 24 23:06:27 2011 +0300

    vdsm-logrotate: remove leftovers of coredump handling
    
    commit 626c4b4f6 moved compression of coredumps into
    vdsm-logrotate.conf, but left error-handling code in vdsm-logrotate.
    
    Change-Id: I244cf610261dce01b8c182fd6b25c200b6fe2c36

diff --git a/vdsm/vdsm-logrotate b/vdsm/vdsm-logrotate
index efa9e09..a641f36 100755
--- a/vdsm/vdsm-logrotate
+++ b/vdsm/vdsm-logrotate
@@ -7,9 +7,4 @@ if [ $EXITVALUE != 0 ]; then
     /usr/bin/logger -t logrotate "ALERT exited abnormally with [$EXITVALUE]"
 fi
 
-EXITVALUE=$?
-if [ $EXITVALUE != 0 ]; then
-    /usr/bin/logger -t logrotate "ALERT clean old core files exited abnormally with
[$EXITVALUE]"
-fi
-
 exit $EXITVALUE

Change in vdsm[master]: vdsm-logrotate: remove leftovers of coredump handling

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: vdsm-logrotate: remove leftovers of coredump handling
......................................................................


vdsm-logrotate: remove leftovers of coredump handling

commit 626c4b4f6 moved compression of coredumps into
vdsm-logrotate.conf, but left error-handling code in vdsm-logrotate.

Change-Id: I244cf610261dce01b8c182fd6b25c200b6fe2c36
---
M vdsm/vdsm-logrotate
1 file changed, 0 insertions(+), 5 deletions(-)

Approvals:
  Dan Kenigsberg: Verified
  Federico Simoncelli: Looks good to me, approved


--
To view, visit http://gerrit.usersys.redhat.com/741
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I244cf610261dce01b8c182fd6b25c200b6fe2c36
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

Change in vdsm[master]: vdsm-logrotate: remove leftovers of coredump handling

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm-logrotate: remove leftovers of coredump handling
......................................................................


Patch Set 1: Verified

--
To view, visit http://gerrit.usersys.redhat.com/741
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I244cf610261dce01b8c182fd6b25c200b6fe2c36
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

Change in vdsm[master]: vdsm-logrotate: remove leftovers of coredump handling

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: vdsm-logrotate: remove leftovers of coredump handling
......................................................................


Patch Set 1: Looks good to me, approved

My bad.

--
To view, visit http://gerrit.usersys.redhat.com/741
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I244cf610261dce01b8c182fd6b25c200b6fe2c36
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;