Change in vdsm[master]: Fixing start return the return value of vdsm execution

Yaniv Bronhaim has uploaded a new change for review.

Change subject: Fixing start return the return value of vdsm execution
......................................................................

Fixing start return the return value of vdsm execution

Change-Id: Ibf04bd53322fc08b0cb8dfa45931ac4eb0c0a25c
Signed-off-by: Yaniv Bronhaim 
---
M init/sysvinit/vdsmd.init.in
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/18804/1

diff --git a/init/sysvinit/vdsmd.init.in b/init/sysvinit/vdsmd.init.in
index b023fb9..9e96730 100755
--- a/init/sysvinit/vdsmd.init.in
+++ b/init/sysvinit/vdsmd.init.in
@@ -146,6 +146,7 @@
         --daemon --masterpid "${RESPAWNPIDFILE}" "${VDSM_BIN}" --pidfile "${PIDFILE}"
     RETVAL=$?
     [ "$RETVAL" -eq 0 ] && log_success_msg $"$prog start" || log_failure_msg $"$prog start"
+    return "$RETVAL"
 }

stop() {

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fixing start return the return value of vdsm execution
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4253/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3358/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4174/ : SUCCESS

Zhou Zheng Sheng has posted comments on this change.

Change subject: Fixing start return the return value of vdsm execution
......................................................................

Patch Set 1: Code-Review+1

[Alon Bar-Lev]

Alon Bar-Lev has posted comments on this change.

Change subject: Fixing start return the return value of vdsm execution
......................................................................

Patch Set 1: Code-Review+1

[Alon Bar-Lev]

Alon Bar-Lev has posted comments on this change.

Change subject: Fixing start return the return value of vdsm execution
......................................................................

Patch Set 1:

can we merge this one?

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Fixing start return the return value of vdsm execution
......................................................................

Patch Set 1: Verified+1 Code-Review+2

Not verified by me, but still.

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Fixing start return the return value of vdsm execution
......................................................................

Fixing start return the return value of vdsm execution

Change-Id: Ibf04bd53322fc08b0cb8dfa45931ac4eb0c0a25c
Signed-off-by: Yaniv Bronhaim 
Reviewed-on: http://gerrit.ovirt.org/18804
Reviewed-by: Zhou Zheng Sheng 
Reviewed-by: Alon Bar-Lev 
Reviewed-by: Dan Kenigsberg 
Tested-by: Dan Kenigsberg 
---
M init/sysvinit/vdsmd.init.in
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Alon Bar-Lev: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved
  Zhou Zheng Sheng: Looks good to me, but someone else must approve