Change in vdsm[master]: pyroute2: redundant args removed from createLibvirtNetwork

Petr Horáček has uploaded a new change for review.

Change subject: pyroute2: redundant args removed from createLibvirtNetwork
......................................................................

pyroute2: redundant args removed from createLibvirtNetwork

pyroute_two.py:createLibvirtNetwork() uses args qosInbound and
qosOutbound. These arguments aren't accepted by libvirt.createNetwork
anymore.

Redundant args was removed.

Change-Id: Ia175edd5d9b6b98fa9c92f4beebd1ae0fef24518
Signed-off-by: Petr Horáček <phoracek(a)redhat.com&gt;
---
M vdsm/network/configurators/pyroute_two.py
1 file changed, 2 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/34198/1

diff --git a/vdsm/network/configurators/pyroute_two.py
b/vdsm/network/configurators/pyroute_two.py
index 4986c12..08df1c4 100644
--- a/vdsm/network/configurators/pyroute_two.py
+++ b/vdsm/network/configurators/pyroute_two.py
@@ -156,10 +156,8 @@
             with open(netinfo.BONDING_OPT % (bond.name, key), 'w') as f:
                 f.write(value)
 
-    def createLibvirtNetwork(self, network, bridged, iface, qosInbound=None,
-                             qosOutbound=None):
-        netXml = libvirt.createNetworkDef(network, bridged, iface,
-                                          qosInbound, qosOutbound)
+    def createLibvirtNetwork(self, network, bridged, iface):
+        netXml = libvirt.createNetworkDef(network, bridged, iface)
         libvirt.createNetwork(netXml)
 
     def removeLibvirtNetwork(self, network):


-- 
To view, visit http://gerrit.ovirt.org/34198
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia175edd5d9b6b98fa9c92f4beebd1ae0fef24518
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: pyroute2: redundant args removed from createLibvirtNetwork
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/34198/1//COMMIT_MSG
Commit Message:

Line 7: pyroute2: redundant args removed from createLibvirtNetwork
Line 8: 
Line 9: pyroute_two.py:createLibvirtNetwork() uses args qosInbound and
Line 10: qosOutbound. These arguments aren't accepted by libvirt.createNetwork
Line 11: anymore.
please state which commit changed the signature of libvirt.createNetwork and forgot fixing
pyroute2.

I see that we have other inconsistencies in the signature of createLibvirtNetwork. Could
you fix them, too? (may be in another patch)

 $ git grep -A1 'def createLibvirt'|cat
 vdsm/network/configurators/ifcfg.py:    def createLibvirtNetwork(self, network,
bridged=True, iface=None,
 vdsm/network/configurators/ifcfg.py-                             skipBackup=False):
 --
 vdsm/network/configurators/iproute2.py:    def createLibvirtNetwork(self, network,
bridged, iface):
 vdsm/network/configurators/iproute2.py-        netXml = libvirt.createNetworkDef(network,
bridged, iface)
 --
 vdsm/network/configurators/pyroute_two.py:    def createLibvirtNetwork(self, network,
bridged, iface, qosInbound=None,
 vdsm/network/configurators/pyroute_two.py-                            
qosOutbound=None):
Line 12: 
Line 13: Redundant args was removed.
Line 14: 
Line 15: Change-Id: Ia175edd5d9b6b98fa9c92f4beebd1ae0fef24518


-- 
To view, visit http://gerrit.ovirt.org/34198
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia175edd5d9b6b98fa9c92f4beebd1ae0fef24518
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

Petr Horáček has posted comments on this change.

Change subject: pyroute2: redundant args removed from createLibvirtNetwork
......................................................................


Patch Set 1: Code-Review-1

Not solving the base problem.

-- 
To view, visit http://gerrit.ovirt.org/34198
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia175edd5d9b6b98fa9c92f4beebd1ae0fef24518
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: pyroute2: redundant args removed from createLibvirtNetwork
......................................................................


Patch Set 1:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12975/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12817/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12026/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/... : There was
an infra issue, please contact infra(a)ovirt.org

-- 
To view, visit http://gerrit.ovirt.org/34198
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia175edd5d9b6b98fa9c92f4beebd1ae0fef24518
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: network: unified configureLibvirtNetwork parameters

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: network: unified configureLibvirtNetwork parameters
......................................................................


network: unified configureLibvirtNetwork parameters

configureLibvirtNetwork() parameters in iproute2 and pyroute_two
configurators are changed to fit the ifcfg's ones which was introduced
in 122c03886c4f42aa8c563e429aa7f4a9a1eb5a5b.

Change-Id: Ia175edd5d9b6b98fa9c92f4beebd1ae0fef24518
Signed-off-by: Petr Horáček <phoracek(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/34198
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M vdsm/network/configurators/iproute2.py
M vdsm/network/configurators/pyroute_two.py
2 files changed, 3 insertions(+), 5 deletions(-)

Approvals:
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/34198
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia175edd5d9b6b98fa9c92f4beebd1ae0fef24518
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: network: unified configureLibvirtNetwork parameters

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: network: unified configureLibvirtNetwork parameters
......................................................................


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/34198
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia175edd5d9b6b98fa9c92f4beebd1ae0fef24518
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: network: unified configureLibvirtNetwork parameters

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: network: unified configureLibvirtNetwork parameters
......................................................................


Patch Set 3:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el6-x86_64_m... :
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/288/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-fc20-x86_64_... :
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/505/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el7-x86_64_m... :
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/304/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4298/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/310/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/312/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-fc21-x86_64_... :
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6135/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/34198
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia175edd5d9b6b98fa9c92f4beebd1ae0fef24518
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: network: unified configureLibvirtNetwork parameters

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: network: unified configureLibvirtNetwork parameters
......................................................................


Patch Set 2:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12713/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13665/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/... : There was
an infra issue, please contact infra(a)ovirt.org

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13503/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/282/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/34198
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia175edd5d9b6b98fa9c92f4beebd1ae0fef24518
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: network: unified configureLibvirtNetwork parameters

Petr Horáček has posted comments on this change.

Change subject: network: unified configureLibvirtNetwork parameters
......................................................................


Patch Set 2: Verified+1

Doesn't affect the results of ifcfg and iproute network functional tests.

Fixed pyroute2 configurator parameters problem:

TypeError: createNetworkDef() takes at most 3 arguments (5 given)

-- 
To view, visit http://gerrit.ovirt.org/34198
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia175edd5d9b6b98fa9c92f4beebd1ae0fef24518
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No