Change in vdsm[master]: vdsm startup: fix assert statement

[Dan Kenigsberg]

Dan Kenigsberg has uploaded a new change for review.

Change subject: vdsm startup: fix assert statement
......................................................................

vdsm startup: fix assert statement

SyntaxWarning: assertion is always true, perhaps remove parentheses?

Change-Id: I0b8cb905494b0719147bf299bb6411c3c4616407
Signed-off-by: Dan Kenigsberg 
---
M vdsm/vdsm
1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/9745/1

diff --git a/vdsm/vdsm b/vdsm/vdsm
index 035ea5d..5c81a40 100755
--- a/vdsm/vdsm
+++ b/vdsm/vdsm
@@ -118,9 +118,9 @@
         "to run from user %s" % (constants.VDSM_USER, username)
     )
     group = grp.getgrnam(constants.VDSM_GROUP)
-    assert ((constants.VDSM_USER in group.gr_mem
-             or pwd.getpwnam(constants.VDSM_USER).pw_gid == group.gr_gid),
-                "VDSM failed to start: vdsm user is not in KVM group")
+    assert (constants.VDSM_USER in group.gr_mem
+            or pwd.getpwnam(constants.VDSM_USER).pw_gid == group.gr_gid), \
+        "VDSM failed to start: vdsm user is not in KVM group"

if __name__ == '__main__':
     __assertVdsmUser()

--
To view, visit http://gerrit.ovirt.org/9745
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b8cb905494b0719147bf299bb6411c3c4616407
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm startup: fix assert statement
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/239/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9745
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b8cb905494b0719147bf299bb6411c3c4616407
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm startup: fix assert statement
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/205/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9745
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b8cb905494b0719147bf299bb6411c3c4616407
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm startup: fix assert statement
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/205/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/239/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/9745
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b8cb905494b0719147bf299bb6411c3c4616407
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm startup: fix assert statement
......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/226/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9745
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b8cb905494b0719147bf299bb6411c3c4616407
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm startup: fix assert statement
......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/260/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9745
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b8cb905494b0719147bf299bb6411c3c4616407
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm startup: fix assert statement
......................................................................

Patch Set 2: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/226/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/260/ : FAILURE

--
To view, visit http://gerrit.ovirt.org/9745
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b8cb905494b0719147bf299bb6411c3c4616407
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm startup: fix assert statement
......................................................................

Patch Set 2: Verified; Looks good to me, but someone else must approve

I didn't see the warning

thanks!

--
To view, visit http://gerrit.ovirt.org/9745
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b8cb905494b0719147bf299bb6411c3c4616407
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm startup: fix assert statement
......................................................................

Patch Set 2: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/9745
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b8cb905494b0719147bf299bb6411c3c4616407
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: vdsm startup: fix assert statement
......................................................................

vdsm startup: fix assert statement

SyntaxWarning: assertion is always true, perhaps remove parentheses?

Change-Id: I0b8cb905494b0719147bf299bb6411c3c4616407
Signed-off-by: Dan Kenigsberg 
---
M vdsm/vdsm
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Yaniv Bronhaim: Verified; Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/9745
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0b8cb905494b0719147bf299bb6411c3c4616407
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim