Change in vdsm[master]: automation: Enable xunit report

[Nir Soffer]

Nir Soffer has uploaded a new change for review.

Change subject: automation: Enable xunit report
......................................................................

automation: Enable xunit report

This used to segfault python in the past, but I think I fixed the root
cause long time ago.

Trying to use this again since it seems to give interesting output
like the time it took to run each test.

Change-Id: Ie8c09cf21e7cf4a97b7b006f2b3ebe4943ed72b9
Signed-off-by: Nir Soffer 
---
M automation/check-patch.sh
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/46640/1

diff --git a/automation/check-patch.sh b/automation/check-patch.sh
index 15707e8..1dba426 100755
--- a/automation/check-patch.sh
+++ b/automation/check-patch.sh
@@ -14,7 +14,7 @@
 "

./autogen.sh --system --enable-hooks
-make check
+make check NOSE_WITH_XUNIT=1

./automation/build-artifacts.sh

[e-mail] has posted comments on this change.

Change subject: automation: Enable xunit report
......................................................................

Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: automation: Enable xunit report
......................................................................

Patch Set 1:

It this works, will replace https://gerrit.ovirt.org/46639.

[e-mail] has posted comments on this change.

Change subject: automation: Enable xunit report
......................................................................

Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: automation: Enable xunit report
......................................................................

Patch Set 2:

Seems to hang the build during jsonrpc tests.

[e-mail] has posted comments on this change.

Change subject: automation: Enable xunit report
......................................................................

Patch Set 3:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: automation: Enable xunit report
......................................................................

Patch Set 3: Verified+1

The failure in the previous build seems unrelated.

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: automation: Enable xunit report
......................................................................

Patch Set 3:

David: the xml is created successfully at tests/nosetests.xml, but jenkins does not show the report in the ui. Do we need to copy the file to some other directory or change jenkins configuration?

[e-mail] has posted comments on this change.

Change subject: automation: Enable xunit report
......................................................................

Patch Set 4:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: automation: Enable xunit report
......................................................................

Patch Set 4: Verified+1

David Caro has posted comments on this change.

Change subject: automation: Enable xunit report
......................................................................

Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/46640/4/automation/build-artifacts.sh
File automation/build-artifacts.sh:

Line 15: make PYFLAKES=true PEP8=true NOSE_EXCLUDE=.* rpm
Line 16: 
Line 17: find "$BUILDS" \
Line 18:     -iname *.rpm \
Line 19:     -exec mv {} "$EXPORTED_ARTIFACTS/" ;
this will not work, as build-artifacts.sh will be run independently too (the fact that check-patch runs it is to avoid duplicating the code).

Any of the three main scripts (check-patch, check-merged and build-artifacts) should be able to run without any parameters or expecting any env vars (aside from posix ones, $PWD $HOME and such)
Line 20: find "$PWD" \
Line 21:     -maxdepth 1 \
Line 22:     -iname vdsm*.tar.gz \

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: automation: Enable xunit report
......................................................................

Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/46640/4/automation/build-artifacts.sh
File automation/build-artifacts.sh:

Line 15: make PYFLAKES=true PEP8=true NOSE_EXCLUDE=.* rpm
Line 16: 
Line 17: find "$BUILDS" \
Line 18:     -iname *.rpm \
Line 19:     -exec mv {} "$EXPORTED_ARTIFACTS/" ;
> this will not work, as build-artifacts.sh will be run independently too (th

How about:

. common.sh

And have the common vars there?

Having simple scripts that run without arguments or env vars is fine, but duplicating configuration info is not.
Line 20: find "$PWD" \
Line 21:     -maxdepth 1 \
Line 22:     -iname vdsm*.tar.gz \

David Caro has posted comments on this change.

Change subject: automation: Enable xunit report
......................................................................

Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/46640/4/automation/build-artifacts.sh
File automation/build-artifacts.sh:

Line 15: make PYFLAKES=true PEP8=true NOSE_EXCLUDE=.* rpm
Line 16: 
Line 17: find "$BUILDS" \
Line 18:     -iname *.rpm \
Line 19:     -exec mv {} "$EXPORTED_ARTIFACTS/" ;
> How about:

you can do whatever you want in the scripts, if you want to have the common.sh for common stuff go for it, as long as the ci can run the script without params or custom env vars it's perfectly fine
Line 20: find "$PWD" \
Line 21:     -maxdepth 1 \
Line 22:     -iname vdsm*.tar.gz \

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: automation: Enable xunit report
......................................................................

Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/46640/4/automation/build-artifacts.sh
File automation/build-artifacts.sh:

Line 15: make PYFLAKES=true PEP8=true NOSE_EXCLUDE=.* rpm
Line 16: 
Line 17: find "$BUILDS" \
Line 18:     -iname *.rpm \
Line 19:     -exec mv {} "$EXPORTED_ARTIFACTS/" ;
> you can do whatever you want in the scripts, if you want to have the common

ok. What about the path of the xml - so we have to copy it to specific location
so jenkins will display the xml report? Or maybe we should configure the 
job for this?

If jenkins does not use this report, there is no point to create it.
Line 20: find "$PWD" \
Line 21:     -maxdepth 1 \
Line 22:     -iname vdsm*.tar.gz \

David Caro has posted comments on this change.

Change subject: automation: Enable xunit report
......................................................................

Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/46640/4/automation/build-artifacts.sh
File automation/build-artifacts.sh:

Line 15: make PYFLAKES=true PEP8=true NOSE_EXCLUDE=.* rpm
Line 16: 
Line 17: find "$BUILDS" \
Line 18:     -iname *.rpm \
Line 19:     -exec mv {} "$EXPORTED_ARTIFACTS/" ;
> ok. What about the path of the xml - so we have to copy it to specific loca

jenkins does not use it yet, if you archive it (put it under exported-artifacts) there's an effort to show the report in jenknis (not only for vdsm, but generically for any standard-ci job), so it will be shown once that is merged. No action will be taken about it though, if you want to fail (or not) you'll have to parse the report yourself and return != 0 if you want to fail
Line 20: find "$PWD" \
Line 21:     -maxdepth 1 \
Line 22:     -iname vdsm*.tar.gz \

[Nir Soffer]

Nir Soffer has abandoned this change.

Change subject: automation: Enable xunit report
......................................................................

Abandoned

Waiting until jenkins will use this file.

[e-mail] has posted comments on this change.

Change subject: automation: Enable xunit report
......................................................................

Patch Set 4:

* Update tracker::IGNORE, no Bug-Url found

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: automation: Enable xunit report
......................................................................

Abandoned

Abandoned due to no activity - please restore if still relevant

gerrit-hooks has posted comments on this change.

Change subject: automation: Enable xunit report
......................................................................

Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found