Change in vdsm[master]: engine.py: replace ping

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has uploaded a new change for review.

Change subject: engine.py: replace ping
......................................................................

engine.py: replace ping

Instead of use ping to reach oVirt Engine (which might be blocked) use
http request via httplib.

Change-Id: I55b01d8a3c5914a9dc2e36bd4f5b7c195283d109
Signed-off-by: Douglas Schilling Landgraf 
---
M vdsm_reg/engine.py.in
1 file changed, 5 insertions(+), 4 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/6254/1
--
To view, visit http://gerrit.ovirt.org/6254
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I55b01d8a3c5914a9dc2e36bd4f5b7c195283d109
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: engine.py: replace ping
......................................................................

Patch Set 1: Verified

In RHEVM:

iptables -F
iptables -A -INPUT -p icmp --icmp-type echo-request -j REJECT

<Tried to register without/with patch>

--
To view, visit http://gerrit.ovirt.org/6254
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55b01d8a3c5914a9dc2e36bd4f5b7c195283d109
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Michael Burns

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: engine.py: replace ping
......................................................................

Patch Set 1: I would prefer that you didn't submit this

I will submit a new code.

--
To view, visit http://gerrit.ovirt.org/6254
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55b01d8a3c5914a9dc2e36bd4f5b7c195283d109
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Michael Burns

Change in vdsm[master]: engine.py: remove ping from write_vdsm_config

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: engine.py: remove ping from write_vdsm_config
......................................................................

Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/6254
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55b01d8a3c5914a9dc2e36bd4f5b7c195283d109
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Michael Burns

Change in vdsm[master]: engine.py: remove ping from write_vdsm_config

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: engine.py: remove ping from write_vdsm_config
......................................................................

engine.py: remove ping from write_vdsm_config

def action() already uses http request to verify if oVirt Engine
is available, we don't need a new 'ping' for write_vdsm_config().

Change-Id: I55b01d8a3c5914a9dc2e36bd4f5b7c195283d109
Signed-off-by: Douglas Schilling Landgraf 
---
M vdsm_reg/engine.py.in
1 file changed, 7 insertions(+), 11 deletions(-)

Approvals:
  Douglas Schilling Landgraf: Verified
  Dan Kenigsberg: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/6254
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I55b01d8a3c5914a9dc2e36bd4f5b7c195283d109
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Michael Burns

Change in vdsm[master]: engine.py: remove ping from write_vdsm_config

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: engine.py: remove ping from write_vdsm_config
......................................................................

Patch Set 2: Looks good to me, approved

removing code is divine.

--
To view, visit http://gerrit.ovirt.org/6254
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55b01d8a3c5914a9dc2e36bd4f5b7c195283d109
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Michael Burns