Change in vdsm[master]: tests: Fail if abort was not called

[Nir Soffer]

Nir Soffer has uploaded a new change for review.

Change subject: tests: Fail if abort was not called
......................................................................

tests: Fail if abort was not called

The StuckJob was waiting one second and terminating silently even if the
test never called abort. Now we raise RuntimeError in this case.

Change-Id: If71d2aeeb4a4242678253845071f68f3a9b12f5d
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com&gt;
---
M tests/jobsTests.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/65207/1

diff --git a/tests/jobsTests.py b/tests/jobsTests.py
index 3b39277..520c98d 100644
--- a/tests/jobsTests.py
+++ b/tests/jobsTests.py
@@ -85,7 +85,8 @@
 
     def _run(self):
         self.event_running.set()
-        self.event_aborted.wait(1)
+        if not self.event_aborted.wait(1):
+            raise RuntimeError("Timeout waiting for abort")
 
     def _abort(self):
         self.event_aborted.set()


-- 
To view, visit https://gerrit.ovirt.org/65207
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If71d2aeeb4a4242678253845071f68f3a9b12f5d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com&gt;

gerrit-hooks has posted comments on this change.

Change subject: tests: Fail if abort was not called
......................................................................


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE,         Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65207
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If71d2aeeb4a4242678253845071f68f3a9b12f5d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

gerrit-hooks has posted comments on this change.

Change subject: tests: Fail if abort was not called
......................................................................


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE,         Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65207
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If71d2aeeb4a4242678253845071f68f3a9b12f5d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No