Change in vdsm[master]: virt: Use a variable for self._vm in MonitorThread action ha...

Milan Zamazal has uploaded a new change for review.

Change subject: virt: Use a variable for self._vm in MonitorThread action handling
......................................................................

virt: Use a variable for self._vm in MonitorThread action handling

This is a reformatting patch to prevent further line breaking in a
followup patch.

Change-Id: I3e41f8b3ef27319c51e18ad2c75bbb3c61b61c76
Signed-off-by: Milan Zamazal 
---
M vdsm/virt/migration.py
1 file changed, 6 insertions(+), 6 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/63553/9

diff --git a/vdsm/virt/migration.py b/vdsm/virt/migration.py
index 4633d47..6cd88f4 100644
--- a/vdsm/virt/migration.py
+++ b/vdsm/virt/migration.py
@@ -783,19 +783,19 @@

def _execute_action_with_params(self, action_with_params):
         action = str(action_with_params['name'])
+        vm = self._vm
         if action == CONVERGENCE_SCHEDULE_SET_DOWNTIME:
             downtime = int(action_with_params['params'][0])
-            self._vm.log.debug('Setting downtime to %d',
-                               downtime)
-            self._vm._dom.migrateSetMaxDowntime(downtime, 0)
+            vm.log.debug('Setting downtime to %d', downtime)
+            vm._dom.migrateSetMaxDowntime(downtime, 0)
         elif action == CONVERGENCE_SCHEDULE_POST_COPY:
             if not self._vm.switch_migration_to_post_copy():
                 # Do nothing for now; the next action will be invoked after a
                 # while
-                self._vm.log.warn('Failed to switch to post-copy migration')
+                vm.log.warn('Failed to switch to post-copy migration')
         elif action == CONVERGENCE_SCHEDULE_SET_ABORT:
-            self._vm.log.warn('Aborting migration')
-            self._vm._dom.abortJob()
+            vm.log.warn('Aborting migration')
+            vm._dom.abortJob()
             self.stop()

gerrit-hooks has posted comments on this change.

Change subject: virt: Use a variable for self._vm in MonitorThread action handling
......................................................................

Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE,         Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])

gerrit-hooks has posted comments on this change.

Change subject: virt: Use a variable for self._vm in MonitorThread action handling
......................................................................

Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE,         Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])

Milan Zamazal has posted comments on this change.

Change subject: virt: Use a variable for self._vm in MonitorThread action handling
......................................................................

Patch Set 9:

Rebase + resolved conflicts.

Francesco Romani has posted comments on this change.

Change subject: virt: Use a variable for self._vm in MonitorThread action handling
......................................................................

Patch Set 9: Code-Review+2

I usually avoid temporaries unless they are justified. Here there is a good justification.

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: Use a variable for self._vm in MonitorThread action handling
......................................................................

virt: Use a variable for self._vm in MonitorThread action handling

This is a reformatting patch to prevent further line breaking in a
followup patch.

Change-Id: I3e41f8b3ef27319c51e18ad2c75bbb3c61b61c76
Signed-off-by: Milan Zamazal 
Bug-Url: https://bugzilla.redhat.com/1354343
---
M vdsm/virt/migration.py
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Milan Zamazal: Verified