Change in vdsm[ovirt-3.6]: spec: Require newer kernel version for RHEL

[Nir Soffer]

Hello Dan Kenigsberg, Francesco Romani,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/47500

to review the following change.

Change subject: spec: Require newer kernel version for RHEL
......................................................................

spec: Require newer kernel version for RHEL

iSCSI default replacement_timeout is 120 seconds, resulting in too slow
iSCSI failover in multipath setup. In vdsm, this may lead to blocking of
multiple unrelated vdsm threads for many minutes, when lvm, multipath
ore scsi scan operation blocks.

This issue was resolved in multipath (BZ1099932), by configuring iscsi
session recovery_tmo sysfs attribute to multipath fast_io_fail_tmo
value, (5 seconds in vdsm configuration). However, this configuration
was reverted to the default 120 seconds after a device went down an up
again, or after restart of the iscsid daemon (BZ1139038).

This issue was fixed in kernel 3.10.0-229.17.1.el7. In this version,
setting session recovery_tmo using sysfs overrides the default value
defined in iscsid configuration file.

This fix is not available in CentOS, so we require the new kernel only
when RHEV build.

Change-Id: I91c2c6b268d728ba6cee0232f72fe2459baa1ca2
Bug-Url: https://bugzilla.redhat.com/980139
Backport-To: 3.6
Backport-To: 3.5
Relates-To: https://bugzilla.redhat.com/1099932
Relates-To: https://bugzilla.redhat.com/1139038
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/47078
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-by: Dan Kenigsberg 
---
M vdsm.spec.in
1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/47500/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index d79964e..6cbd119 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -179,7 +179,11 @@
 Requires: device-mapper-multipath >= 0.4.9-68
 Requires: e2fsprogs
 Requires: fence-agents-all
+%if 0%{?centos}
 Requires: kernel >= 3.10.0-132.el7
+%else
+Requires: kernel >= 3.10.0-229.17.1.el7
+%endif
 Requires: lvm2 >= 2.02.107
 Requires: python >= 2.7.5-18.el7_1.1
 Requires: policycoreutils-python

[e-mail] has posted comments on this change.

Change subject: spec: Require newer kernel version for RHEL
......................................................................

Patch Set 1:

* Update tracker::#980139::OK
* Check Bug-Url::OK
* Check Public Bug::#980139::OK, public bug
* Check Product::#980139::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: spec: Require newer kernel version for RHEL
......................................................................

Patch Set 1: Verified+1

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: spec: Require newer kernel version for RHEL
......................................................................

Patch Set 1:

Verified on master.

Francesco Romani has posted comments on this change.

Change subject: spec: Require newer kernel version for RHEL
......................................................................

Patch Set 1: Code-Review+2

[e-mail] has posted comments on this change.

Change subject: spec: Require newer kernel version for RHEL
......................................................................

Patch Set 2:

* Update tracker::#980139::OK
* Check Bug-Url::OK
* Check Public Bug::#980139::OK, public bug
* Check Product::#980139::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

Francesco Romani has submitted this change and it was merged.

Change subject: spec: Require newer kernel version for RHEL
......................................................................

spec: Require newer kernel version for RHEL

iSCSI default replacement_timeout is 120 seconds, resulting in too slow
iSCSI failover in multipath setup. In vdsm, this may lead to blocking of
multiple unrelated vdsm threads for many minutes, when lvm, multipath
ore scsi scan operation blocks.

This issue was resolved in multipath (BZ1099932), by configuring iscsi
session recovery_tmo sysfs attribute to multipath fast_io_fail_tmo
value, (5 seconds in vdsm configuration). However, this configuration
was reverted to the default 120 seconds after a device went down an up
again, or after restart of the iscsid daemon (BZ1139038).

This issue was fixed in kernel 3.10.0-229.17.1.el7. In this version,
setting session recovery_tmo using sysfs overrides the default value
defined in iscsid configuration file.

This fix is not available in CentOS, so we require the new kernel only
for RHEL.

Change-Id: I91c2c6b268d728ba6cee0232f72fe2459baa1ca2
Bug-Url: https://bugzilla.redhat.com/980139
Backport-To: 3.6
Backport-To: 3.5
Relates-To: https://bugzilla.redhat.com/1099932
Relates-To: https://bugzilla.redhat.com/1139038
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/47078
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/47500
---
M vdsm.spec.in
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved

[e-mail] has posted comments on this change.

Change subject: spec: Require newer kernel version for RHEL
......................................................................

Patch Set 3:

* Update tracker::#980139::OK
* Set MODIFIED::bug 980139::::#980139::::IGNORE, not oVirt prod but Red Hat Enterprise Virtualization Manager