Change in vdsm[master]: [WIP] add host-cpu to api

Laszlo Hornyak has uploaded a new change for review.

Change subject: [WIP] add host-cpu to api
......................................................................

[WIP] add host-cpu to api

work in progress

Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Signed-off-by: Laszlo Hornyak 
---
M vdsm/libvirtvm.py
M vdsm_api/vdsmapi-schema.json
2 files changed, 12 insertions(+), 2 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/9367/1

diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py
index 3439dc3..52a45b4 100644
--- a/vdsm/libvirtvm.py
+++ b/vdsm/libvirtvm.py
@@ -748,6 +748,11 @@
                 cputune.appendChild(vcpupin)
             self.dom.appendChild(cputune)

+        #cpu-host support
+        # see http://wiki.ovirt.org/wiki/Features/Cpu-host_Support
+        if 'useHostCpuFlags' in self.conf:
+            cpu.setAttribute('model', 'host-passthrough')
+
         # This hack is for backward compatibility as the libvirt does not allow
         # 'qemu64' guest on intel hardware
         if model == 'qemu64' and not '+svm' in features:
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index 843cbc7..b7bed35 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -2412,6 +2412,8 @@
 #
 # @vmType:                The type of VM
 #
+# @useHostCpuFlags:       use host CPU flags (host-passthrough) in the vcpus
+#
 # Since: 4.10.0
 ##
 {'type': 'VmDefinition',
@@ -2425,7 +2427,8 @@
           'pid': 'uint', 'smp': 'uint', '*smpCoresPerSocket': 'uint',
           '*smpThreadsPerCore': 'uint', 'status': 'VmStatus',
           'timeOffset': 'uint', 'transparentHugePages': 'bool',
-          'vmId': 'UUID', 'vmName': 'str', 'vmType': 'VmType'}}
+          'vmId': 'UUID', 'vmName': 'str', 'vmType': 'VmType',
+          'useHostCpuFlags' : 'bool'}}

##
 # @VmParameters:
@@ -2463,6 +2466,8 @@
 #
 # @vmType:                The type of VM
 #
+# @useHostCpuFlags:       use host CPU flags (host-passthrough) in the vcpus
+#
 # Since: 4.10.0
 ##
 {'type': 'VmParameters',
@@ -2472,7 +2477,7 @@
           'nice': 'int', 'smp': 'uint', 'smpCoresPerSocket': 'uint',
           'smpThreadsPerCore': 'uint', 'timeOffset': 'uint',
           'transparentHugePages': 'bool', 'vmId': 'UUID', 'vmName': 'str',
-          'vmType': 'VmType'}}
+          'vmType': 'VmType', 'useHostCpuFlags' : 'true'}}

##
 # @VmInfo:

--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: [WIP] add host-cpu to api
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/110/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: [WIP] add host-cpu to api
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/76/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: [WIP] add host-cpu to api
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/76/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/110/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak 
Gerrit-Reviewer: oVirt Jenkins CI Server

Royce Lv has posted comments on this change.

Change subject: [WIP] add host-cpu to api
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 750: 
Line 751:         #cpu-host support
Line 752:         # see http://wiki.ovirt.org/wiki/Features/Cpu-host_Support
Line 753:         if 'useHostCpuFlags' in self.conf:
Line 754:             cpu.setAttribute('model', 'host-passthrough')
"host-passthrough" mode is not a model,Neither model nor feature elements are allowed in this mode. see:http://libvirt.org/formatdomain.html#elementsCPU.
I guess this feature needs to disable migration on engine or vdsm side.
Line 755: 
Line 756:         # This hack is for backward compatibility as the libvirt does not allow
Line 757:         # 'qemu64' guest on intel hardware
Line 758:         if model == 'qemu64' and not '+svm' in features:

--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: oVirt Jenkins CI Server

Deepak C Shetty has posted comments on this change.

Change subject: [WIP] add host-cpu to api
......................................................................

Patch Set 1:

+1 to lyroyce's comment. host-passthrough is not a model.

--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: oVirt Jenkins CI Server

Deepak C Shetty has posted comments on this change.

Change subject: [WIP] add host-cpu to api
......................................................................

Patch Set 1: (1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 751:         #cpu-host support
Line 752:         # see http://wiki.ovirt.org/wiki/Features/Cpu-host_Support
Line 753:         if 'useHostCpuFlags' in self.conf:
Line 754:             cpu.setAttribute('model', 'host-passthrough')
Line 755: 
Why not add support for host-model as well , which AFAIU does not block migration. Why only host-passthrough ? In the UI if migration is allowed, host-model will be used when the appropriate check box is checked by user.
Line 756:         # This hack is for backward compatibility as the libvirt does not allow
Line 757:         # 'qemu64' guest on intel hardware
Line 758:         if model == 'qemu64' and not '+svm' in features:
Line 759:             features += ['-svm']

--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: oVirt Jenkins CI Server

Laszlo Hornyak has posted comments on this change.

Change subject: [WIP] add host-cpu to api
......................................................................

Patch Set 1:

Hi,

Thanks for the comments, this patch is WIP and trying to get an agreement with the vdsm developers on how to implement it.

--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: [WIP] add host-cpu to api
......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/135/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: [WIP] add host-cpu to api
......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/101/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: [WIP] add host-cpu to api
......................................................................

Patch Set 2:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/101/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/135/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: [WIP] add host-cpu to api
......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/107/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: [WIP] add host-cpu to api
......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/141/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: [WIP] add host-cpu to api
......................................................................

Patch Set 3:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/107/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/141/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: [WIP] add host-cpu to api
......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/142/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: [WIP] add host-cpu to api
......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/108/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: [WIP] add host-cpu to api
......................................................................

Patch Set 4: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/108/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/142/ : FAILURE

--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: oVirt Jenkins CI Server

Laszlo Hornyak has posted comments on this change.

Change subject: [WIP] add host-cpu to api
......................................................................

Patch Set 4:

fixed typos, commit msg

please review

thx

--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: oVirt Jenkins CI Server

Doron Fediuck has posted comments on this change.

Change subject: [WIP] add host-cpu to api
......................................................................

Patch Set 4: (1 inline comment)

Laszlo, still an extra space there.

....................................................
File vdsm_api/vdsmapi-schema.json
Line 2411: # @vmName:                The VM name
Line 2412: #
Line 2413: # @vmType:                The type of VM
Line 2414: #
Line 2415: # @cpuMode:               the cpu mode 
Please remove TWS.
Line 2416: #                         see http://libvirt.org/formatdomain.html#elementsCPU
Line 2417: #
Line 2418: # Since: 4.10.0
Line 2419: ##

--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: [WIP] add host-cpu to api
......................................................................

Patch Set 5:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/143/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: [WIP] add host-cpu to api
......................................................................

Patch Set 5:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/177/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: oVirt Jenkins CI Server

Laszlo Hornyak has posted comments on this change.

Change subject: [WIP] add host-cpu to api
......................................................................

Patch Set 5:

removed mctws

--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: [WIP] add host-cpu to api
......................................................................

Patch Set 5:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/143/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/177/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: oVirt Jenkins CI Server

Doron Fediuck has posted comments on this change.

Change subject: [WIP] add host-cpu to api
......................................................................

Patch Set 5: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: [WIP] add host-cpu to api
......................................................................

Patch Set 5: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 750: 
Line 751:         #cpu-host support
Line 752:         # see http://wiki.ovirt.org/wiki/Features/Cpu-host_Support
Line 753:         if 'cpuMode' in self.conf:
Line 754:             cpu.setAttribute('mode', self.conf.get('cpuMode'))
I do not understand why this is orthogonal to cpuType. Does it make any sense to require both cpuType=Nehalem and set cpuMode?
> From http://libvirt.org/formatdomain.html#elementsCPU it seems that the answer is no: "Neither model nor feature elements are allowed in this mode". So I guess that this code won't actually run a VM.

How about a special cpuType=hostPassthrough for obtaining this functionality?
Line 755: 
Line 756:         # This hack is for backward compatibility as the libvirt does not allow
Line 757:         # 'qemu64' guest on intel hardware
Line 758:         if model == 'qemu64' and not '+svm' in features:

--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: oVirt Jenkins CI Server

Laszlo Hornyak has posted comments on this change.

Change subject: [WIP] add host-cpu to api
......................................................................

Patch Set 5: (1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 750: 
Line 751:         #cpu-host support
Line 752:         # see http://wiki.ovirt.org/wiki/Features/Cpu-host_Support
Line 753:         if 'cpuMode' in self.conf:
Line 754:             cpu.setAttribute('mode', self.conf.get('cpuMode'))
Imo in that way we will just mess up the cpuType. We will soon need a cpuType=custom and a cpuType=host-model and what we choose here is not actually a cputype, but the mode we are using the cpu.
Line 755: 
Line 756:         # This hack is for backward compatibility as the libvirt does not allow
Line 757:         # 'qemu64' guest on intel hardware
Line 758:         if model == 'qemu64' and not '+svm' in features:

--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: oVirt Jenkins CI Server

Doron Fediuck has posted comments on this change.

Change subject: [WIP] add host-cpu to api
......................................................................

Patch Set 5: (1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 750: 
Line 751:         #cpu-host support
Line 752:         # see http://wiki.ovirt.org/wiki/Features/Cpu-host_Support
Line 753:         if 'cpuMode' in self.conf:
Line 754:             cpu.setAttribute('mode', self.conf.get('cpuMode'))
Dan, for my own selfish needs I like your offer ;)

But for the sake of future readers, here's some more info;

We need to differ mode from model.

mode is a higher level attribute, which is provided to "make it easier to configure a guest CPU to be as close to host CPU as possible". The default mode is "custom", which means "the cpu element describes the CPU that should be presented to the guest.".

model, along with the topology, vendor and other attributes will be used to describe the pCPU for the guest OS.

So you actually do not need the latter in passthrough mode, as you can now understand. These modes (custom VS host-passthrough) are actually mutually exclusive.

So for future vdsm needs mode should be added. For my current needs your offer is good enough. Going forward we cannot help but adding cpu mode.
Line 755: 
Line 756:         # This hack is for backward compatibility as the libvirt does not allow
Line 757:         # 'qemu64' guest on intel hardware
Line 758:         if model == 'qemu64' and not '+svm' in features:

--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: oVirt Jenkins CI Server

Laszlo Hornyak has abandoned this change.

Change subject: [WIP] add host-cpu to api
......................................................................

Patch Set 5: Abandoned

not needed anymore

--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: oVirt Jenkins CI Server