Change in vdsm[ovirt-3.5]: spec: Require newer kernel version on Fedora

[Nir Soffer]

Hello Piotr Kliczewski, Dan Kenigsberg, Allon Mureinik, Francesco Romani,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/47473

to review the following change.

Change subject: spec: Require newer kernel version on Fedora
......................................................................

spec: Require newer kernel version on Fedora

iSCSI default replacement_timeout is 120 seconds, resulting in too slow
iSCSI failover in multipath setup. In vdsm, this may lead to blocking of
multiple unrelated vdsm threads for many minutes, when lvm, multipath
ore scsi scan operation blocks.

This issue was resolved in multipath (BZ1099932), by configuring iscsi
session recovery_tmo sysfs attribute to multipath fast_io_fail_tmo
value, (5 seconds in vdsm configuration). However, this configuration
was reverted to the default 120 seconds after a device went down an up
again, or after restart of the iscsid daemon (BZ1139038).

This issue was fixed in kernel 4.1.6. In this version, setting session
recovery_tmo using sysfs overrides the default value defined in iscsid
configuration file.

We have the same issue on EL; this is handled in a separate patch since
the package is not available yet on CentOS.

Change-Id: I9cdf2102fe567c6d087d9ef650d21ee34640a33a
Bug-Url: https://bugzilla.redhat.com/1253790
Backport-To: 3.6
Backport-To: 3.5
Relates-To: https://bugzilla.redhat.com/1099932
Relates-To: https://bugzilla.redhat.com/1139038
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/44851
Continuous-Integration: Jenkins CI
Reviewed-by: Allon Mureinik 
Reviewed-by: Piotr Kliczewski 
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/47207
Reviewed-by: Francesco Romani 
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/47473/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 3a84f90..15103e1 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -243,7 +243,7 @@
 %endif
 %else
 Requires: fence-agents-all
-Requires: kernel >= 3.11.3-201
+Requires: kernel >= 4.1.6
 # Subprocess and thread bug was found on python 2.7.2
 Requires: python >= 2.7.3
 Requires: python-ethtool >= 0.8-1

[e-mail] has posted comments on this change.

Change subject: spec: Require newer kernel version on Fedora
......................................................................

Patch Set 1:

* Update tracker::#1253790::OK
* Check Bug-Url::OK
* Check Public Bug::#1253790::OK, public bug
* Check Product::#1253790::OK, Correct classification oVirt
* Check TM::#1253790::ERROR, wrong target milestone for stable branch, ovirt-3.6.0-ga should match ^.*3.5.*
* Check merged to previous::OK, change not open on any previous branch

[e-mail] has posted comments on this change.

Change subject: spec: Require newer kernel version on Fedora
......................................................................

Patch Set 2:

* Update tracker::#1272083::OK
* Check Bug-Url::OK
* Check Public Bug::#1272083::OK, public bug
* Check Product::#1272083::OK, Correct classification oVirt
* Check TM::#1272083::OK, correct target milestone ovirt-3.5.6
* Check merged to previous::OK, change not open on any previous branch

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: spec: Require newer kernel version on Fedora
......................................................................

Patch Set 2: Verified+1

Verified on master.

Francesco Romani has posted comments on this change.

Change subject: spec: Require newer kernel version on Fedora
......................................................................

Patch Set 2: Code-Review+2

Francesco Romani has posted comments on this change.

Change subject: spec: Require newer kernel version on Fedora
......................................................................

Patch Set 2: Continuous-Integration+1

Francesco Romani has posted comments on this change.

Change subject: spec: Require newer kernel version on Fedora
......................................................................

Patch Set 2:

run CI scripts manually.

Francesco Romani has submitted this change and it was merged.

Change subject: spec: Require newer kernel version on Fedora
......................................................................

spec: Require newer kernel version on Fedora

iSCSI default replacement_timeout is 120 seconds, resulting in too slow
iSCSI failover in multipath setup. In vdsm, this may lead to blocking of
multiple unrelated vdsm threads for many minutes, when lvm, multipath
ore scsi scan operation blocks.

This issue was resolved in multipath (BZ1099932), by configuring iscsi
session recovery_tmo sysfs attribute to multipath fast_io_fail_tmo
value, (5 seconds in vdsm configuration). However, this configuration
was reverted to the default 120 seconds after a device went down an up
again, or after restart of the iscsid daemon (BZ1139038).

This issue was fixed in kernel 4.1.6. In this version, setting session
recovery_tmo using sysfs overrides the default value defined in iscsid
configuration file.

We have the same issue on EL; this is handled in a separate patch since
the package is not available yet on CentOS.

Change-Id: I9cdf2102fe567c6d087d9ef650d21ee34640a33a
Bug-Url: https://bugzilla.redhat.com/1272083
Backport-To: 3.6
Backport-To: 3.5
Relates-To: https://bugzilla.redhat.com/1099932
Relates-To: https://bugzilla.redhat.com/1139038
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/44851
Continuous-Integration: Jenkins CI
Reviewed-by: Allon Mureinik 
Reviewed-by: Piotr Kliczewski 
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/47207
Reviewed-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/47473
Continuous-Integration: Francesco Romani 
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Nir Soffer: Verified
  Francesco Romani: Looks good to me, approved; Passed CI tests

[e-mail] has posted comments on this change.

Change subject: spec: Require newer kernel version on Fedora
......................................................................

Patch Set 3:

* Update tracker::#1272083::OK
* Set MODIFIED::bug 1272083::::#1272083::::IGNORE, not oVirt prod but vdsm