3:09 a.m.
Zhou Zheng Sheng has uploaded a new change for review.
Change subject: define qemu process user and group in configure.ac for Ubuntu
......................................................................
define qemu process user and group in configure.ac for Ubuntu
Ubuntu qemu process started by libvirt is libvirt-qemu:kvm, and there
is no group named qemu, only group kvm. This patch sets the correct
value of the variable in configure.ac .
The patch is on going work of porting VDSM to Ubuntu
http://www.ovirt.org/VDSM_on_Ubuntu
Change-Id: I78392b4edcf243e8a2d65b8b18436141e3ed86ea
Signed-off-by: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
---
M configure.ac
1 file changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/15/12915/1
diff --git a/configure.ac b/configure.ac
index 434d209..9aeeb56 100644
--- a/configure.ac
+++ b/configure.ac
@@ -59,8 +59,16 @@
AC_SUBST([VDSMGROUP], [kvm])
AC_SUBST([METADATAUSER], [vdsm])
AC_SUBST([METADATAGROUP], [kvm])
-AC_SUBST([QEMUUSER], [qemu])
-AC_SUBST([QEMUGROUP], [qemu])
+if grep -i fedora /etc/*-release; then
+ AC_SUBST([QEMUUSER], [qemu])
+ AC_SUBST([QEMUGROUP], [qemu])
+elif grep -i ubuntu /etc/*-release; then
+ AC_SUBST([QEMUUSER], [libvirt-qemu])
+ AC_SUBST([QEMUGROUP], [kvm])
+else
+ AC_SUBST([QEMUUSER], [qemu])
+ AC_SUBST([QEMUGROUP], [qemu])
+fi
AC_SUBST([SNLKUSER], [sanlock])
AC_SUBST([SNLKGROUP], [sanlock])
--
To view, visit http://gerrit.ovirt.org/12915
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I78392b4edcf243e8a2d65b8b18436141e3ed86ea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
7:08 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: define qemu process user and group in configure.ac for Ubuntu
......................................................................
define qemu process user and group in configure.ac for Ubuntu
Ubuntu qemu process started by libvirt is libvirt-qemu:kvm, and there
is no group named qemu, only group kvm. This patch sets the correct
value of the variable in configure.ac .
The patch is on going work of porting VDSM to Ubuntu
http://www.ovirt.org/VDSM_on_Ubuntu
Change-Id: I78392b4edcf243e8a2d65b8b18436141e3ed86ea
Signed-off-by: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
---
M configure.ac
1 file changed, 10 insertions(+), 2 deletions(-)
Approvals:
Douglas Schilling Landgraf: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Zhou Zheng Sheng: Verified
--
To view, visit http://gerrit.ovirt.org/12915
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I78392b4edcf243e8a2d65b8b18436141e3ed86ea
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
7:08 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: define qemu process user and group in configure.ac for Ubuntu
......................................................................
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12915
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78392b4edcf243e8a2d65b8b18436141e3ed86ea
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10:03 p.m.
Zhou Zheng Sheng has posted comments on this change.
Change subject: define qemu process user and group in configure.ac for Ubuntu
......................................................................
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/12915
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78392b4edcf243e8a2d65b8b18436141e3ed86ea
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:58 p.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: define qemu process user and group in configure.ac for Ubuntu
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12915
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78392b4edcf243e8a2d65b8b18436141e3ed86ea
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:51 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: define qemu process user and group in configure.ac for Ubuntu
......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1565/ (1/2)
--
To view, visit http://gerrit.ovirt.org/12915
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78392b4edcf243e8a2d65b8b18436141e3ed86ea
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:55 p.m.
Zhou Zheng Sheng has posted comments on this change.
Change subject: define qemu process user and group in configure.ac for Ubuntu
......................................................................
Patch Set 1: (1 inline comment)
Thanks guys.
....................................................
File configure.ac
Line 59: AC_SUBST([VDSMGROUP], [kvm])
Line 60: AC_SUBST([METADATAUSER], [vdsm])
Line 61: AC_SUBST([METADATAGROUP], [kvm])
Line 62: if grep -i fedora /etc/*-release; then
Line 63: AC_SUBST([QEMUUSER], [qemu])
Done
Line 64: AC_SUBST([QEMUGROUP], [qemu])
Line 65: elif grep -i ubuntu /etc/*-release; then
Line 66: AC_SUBST([QEMUUSER], [libvirt-qemu])
Line 67: AC_SUBST([QEMUGROUP], [kvm])
--
To view, visit http://gerrit.ovirt.org/12915
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78392b4edcf243e8a2d65b8b18436141e3ed86ea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:53 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: define qemu process user and group in configure.ac for Ubuntu
......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1565/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1528/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/12915
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78392b4edcf243e8a2d65b8b18436141e3ed86ea
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:51 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: define qemu process user and group in configure.ac for Ubuntu
......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1528/ (2/2)
--
To view, visit http://gerrit.ovirt.org/12915
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78392b4edcf243e8a2d65b8b18436141e3ed86ea
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
5:35 p.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: define qemu process user and group in configure.ac for Ubuntu
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File configure.ac
Line 59: AC_SUBST([VDSMGROUP], [kvm])
Line 60: AC_SUBST([METADATAUSER], [vdsm])
Line 61: AC_SUBST([METADATAGROUP], [kvm])
Line 62: if grep -i fedora /etc/*-release; then
Line 63: AC_SUBST([QEMUUSER], [qemu])
+1
Line 64: AC_SUBST([QEMUGROUP], [qemu])
Line 65: elif grep -i ubuntu /etc/*-release; then
Line 66: AC_SUBST([QEMUUSER], [libvirt-qemu])
Line 67: AC_SUBST([QEMUGROUP], [kvm])
--
To view, visit http://gerrit.ovirt.org/12915
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78392b4edcf243e8a2d65b8b18436141e3ed86ea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8:21 a.m.
ShaoHe Feng has posted comments on this change.
Change subject: define qemu process user and group in configure.ac for Ubuntu
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File configure.ac
Line 59: AC_SUBST([VDSMGROUP], [kvm])
Line 60: AC_SUBST([METADATAUSER], [vdsm])
Line 61: AC_SUBST([METADATAGROUP], [kvm])
Line 62: if grep -i fedora /etc/*-release; then
Line 63: AC_SUBST([QEMUUSER], [qemu])
should same with line 113
Line 64: AC_SUBST([QEMUGROUP], [qemu])
Line 65: elif grep -i ubuntu /etc/*-release; then
Line 66: AC_SUBST([QEMUUSER], [libvirt-qemu])
Line 67: AC_SUBST([QEMUGROUP], [kvm])
--
To view, visit http://gerrit.ovirt.org/12915
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78392b4edcf243e8a2d65b8b18436141e3ed86ea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4:59 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: define qemu process user and group in configure.ac for Ubuntu
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File configure.ac
Line 59: AC_SUBST([VDSMGROUP], [kvm])
Line 60: AC_SUBST([METADATAUSER], [vdsm])
Line 61: AC_SUBST([METADATAGROUP], [kvm])
Line 62: if grep -i fedora /etc/*-release; then
Line 63: AC_SUBST([QEMUUSER], [qemu])
are we happy about tabs here?
Line 64: AC_SUBST([QEMUGROUP], [qemu])
Line 65: elif grep -i ubuntu /etc/*-release; then
Line 66: AC_SUBST([QEMUUSER], [libvirt-qemu])
Line 67: AC_SUBST([QEMUGROUP], [kvm])
--
To view, visit http://gerrit.ovirt.org/12915
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78392b4edcf243e8a2d65b8b18436141e3ed86ea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:17 a.m.
Zhou Zheng Sheng has posted comments on this change.
Change subject: define qemu process user and group in configure.ac for Ubuntu
......................................................................
Patch Set 1:
Run functional tests both on Fedora and Ubuntu.
--
To view, visit http://gerrit.ovirt.org/12915
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78392b4edcf243e8a2d65b8b18436141e3ed86ea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:15 a.m.
Zhou Zheng Sheng has posted comments on this change.
Change subject: define qemu process user and group in configure.ac for Ubuntu
......................................................................
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12915
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78392b4edcf243e8a2d65b8b18436141e3ed86ea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:12 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: define qemu process user and group in configure.ac for Ubuntu
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1545/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1508/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/12915
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78392b4edcf243e8a2d65b8b18436141e3ed86ea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:09 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: define qemu process user and group in configure.ac for Ubuntu
......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1545/ (2/2)
--
To view, visit http://gerrit.ovirt.org/12915
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78392b4edcf243e8a2d65b8b18436141e3ed86ea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:09 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: define qemu process user and group in configure.ac for Ubuntu
......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1508/ (1/2)
--
To view, visit http://gerrit.ovirt.org/12915
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78392b4edcf243e8a2d65b8b18436141e3ed86ea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4099
days inactive
4100
days old
vdsm-patches@lists.fedorahosted.org
16 comments
5 participants
participants (5)
-
Dan Kenigsberg -
Douglas Schilling Landgraf -
Jenkins CI RO -
shaohef＠linux.vnet.ibm.com -
zhshzhou＠linux.vnet.ibm.com