Change in vdsm[master]: (Schema) Replace FloatStr with float

Saggi Mizrahi has uploaded a new change for review.

Change subject: (Schema) Replace FloatStr with float
......................................................................

(Schema) Replace FloatStr with float

Change-Id: I3c01ac527d34419e698123bfecca4ff86eca5450
Signed-off-by: Saggi Mizrahi 
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 10 insertions(+), 19 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/6842/1
--
To view, visit http://gerrit.ovirt.org/6842
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3c01ac527d34419e698123bfecca4ff86eca5450
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi

Adam Litke has posted comments on this change.

Change subject: (Schema) Replace FloatStr with float
......................................................................

Patch Set 1:

Should we use double instead of float?  Might make sense to always have a 64bit value for better precision and range.  Also, we'd just have a single floating point variable type to worry about.

--
To view, visit http://gerrit.ovirt.org/6842
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c01ac527d34419e698123bfecca4ff86eca5450
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg

Adam Litke has posted comments on this change.

Change subject: (Schema) Replace FloatStr with float
......................................................................

Patch Set 3: Looks good to me, but someone else must approve

Regarding the double comment I made against the first series, I can just represent floats as doubles during code generation.

--
To view, visit http://gerrit.ovirt.org/6842
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c01ac527d34419e698123bfecca4ff86eca5450
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi

Saggi Mizrahi has posted comments on this change.

Change subject: (Schema) Replace FloatStr with float
......................................................................

Patch Set 3: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/6842
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c01ac527d34419e698123bfecca4ff86eca5450
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi

Saggi Mizrahi has posted comments on this change.

Change subject: (Schema) Replace FloatStr with float
......................................................................

Patch Set 4: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/6842
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c01ac527d34419e698123bfecca4ff86eca5450
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi

Saggi Mizrahi has submitted this change and it was merged.

Change subject: (Schema) Replace FloatStr with float
......................................................................

(Schema) Replace FloatStr with float

Change-Id: I3c01ac527d34419e698123bfecca4ff86eca5450
Signed-off-by: Saggi Mizrahi 
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 10 insertions(+), 19 deletions(-)

Approvals:
  Saggi Mizrahi: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/6842
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3c01ac527d34419e698123bfecca4ff86eca5450
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi