Change in vdsm[master]: utils: Extend pgrep to accept multiple process names

Ondřej Svoboda has uploaded a new change for review.

Change subject: utils: Extend pgrep to accept multiple process names
......................................................................

utils: Extend pgrep to accept multiple process names

Change-Id: I891ee6c36b4198ce9900e56a62939b9a7bafbc6e
Bug-Url: https://bugzilla.redhat.com/987813
Signed-off-by: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
---
M lib/vdsm/utils.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/23239/1

diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py
index f3b490a..0a5471e 100644
--- a/lib/vdsm/utils.py
+++ b/lib/vdsm/utils.py
@@ -265,12 +265,12 @@
         yield int(pid)
 
 
-def pgrep(name):
+def pgrep(*names):
     res = []
     for pid in iteratePids():
         try:
             procName = pidStat(pid).comm
-            if procName == name:
+            if procName in names:
                 res.append(pid)
         except (OSError, IOError):
             continue


-- 
To view, visit http://gerrit.ovirt.org/23239
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I891ee6c36b4198ce9900e56a62939b9a7bafbc6e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com&gt;

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: utils: Extend pgrep to accept multiple process names
......................................................................


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6718/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6631/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5825/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/23239
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I891ee6c36b4198ce9900e56a62939b9a7bafbc6e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Ondřej Svoboda has abandoned this change.

Change subject: utils: Extend pgrep to accept multiple process names
......................................................................


Abandoned

The ability to pgrep 'dhclient' and 'dhcpcd' in one run was supposed for
an earlier version of the BOOTPROTO patch and even then it was not the best idea as two
loops (for both DHCP clients separately) would not hurt much and would actually result in
cleaner code.

-- 
To view, visit http://gerrit.ovirt.org/23239
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I891ee6c36b4198ce9900e56a62939b9a7bafbc6e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Assaf Muller has posted comments on this change.

Change subject: utils: Extend pgrep to accept multiple process names
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/23239/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 264:         pid = os.path.basename(path)
Line 265:         yield int(pid)
Line 266: 
Line 267: 
Line 268: def pgrep(*names):
>  I think it could use a docstring now. 
While the change is
completely hidden from current users - I agree, it should be explicitly noted that the
function can accept a single or multiple names.
Line 269:     res = []
Line 270:     for pid in iteratePids():
Line 271:         try:
Line 272:             procName = pidStat(pid).comm


-- 
To view, visit http://gerrit.ovirt.org/23239
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I891ee6c36b4198ce9900e56a62939b9a7bafbc6e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

Antoni Segura Puimedon has posted comments on this change.

Change subject: utils: Extend pgrep to accept multiple process names
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/23239/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 264:         pid = os.path.basename(path)
Line 265:         yield int(pid)
Line 266: 
Line 267: 
Line 268: def pgrep(*names):
I think it could use a docstring now.
Line 269:     res = []
Line 270:     for pid in iteratePids():
Line 271:         try:
Line 272:             procName = pidStat(pid).comm


-- 
To view, visit http://gerrit.ovirt.org/23239
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I891ee6c36b4198ce9900e56a62939b9a7bafbc6e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes