From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Fix store net config - delete dir only if existed.
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/76630/2/lib/vdsm/network/netconfpersistence.py
File lib/vdsm/network/netconfpersistence.py:
Line 275
Line 276
Line 277
Line 278
Line 279
I have no crush on the realpath=path.
I prefer Didi's
explicit logic, even though it is more complex.
But let us unbreak o-s-t first, and introduce the clearer code with a proper unit test for
this use case, in a follow-up patch.
--
To view, visit
https://gerrit.ovirt.org/76630
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I92bb69b8b093845069d496e595d5d9476d5be6ee
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman <mburman(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes