Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpc: Create the java bindings and fix bugs ......................................................................
Patch Set 5:
(7 comments)
You have tabs all around in the java files, I comment on some of them.
.................................................... Commit Message Line 3: AuthorDate: 2013-02-07 15:26:39 -0500 Line 4: Commit: Saggi Mizrahi smizrahi@redhat.com Line 5: CommitDate: 2013-09-24 18:04:18 +0300 Line 6: Line 7: jsonrpc: Create the java bindings and fix bugs You can detail a bit more, or forward to wiki page. I mean, detail shortly about yajsonrpc missing parts that you extend here, what changes do you do in the scheme and I guess you can add more information about the java part. Line 8: Line 9: Change-Id: If828355b7efe28fe6a2e784069425fefd2f3f25c
.................................................... File client/java/vdsm-api/src/main/java/org/ovirt/vdsm/VDSMClientBase.java Line 24: return _transport.closed(); Line 25: } Line 26: Line 27: protected <T> Future<VDSMResponse<T>> _call(RequestBuilder rb, Line 28: TypeReference<T> tr) { tabs Line 29: Line 30: final JsonRpcRequest __req = rb.build(); Line 31: final Future<JsonRpcResponse> __call = _transport.call(__req); Line 32: return new FutureResultWrapper<>(
.................................................... File client/java/vdsm-api/src/main/java/org/ovirt/vdsm/VDSMClientPool.java Line 36: Line 37: // package private Line 38: Future<JsonRpcClient> connectToClient(URI uri) { Line 39: final Future<ReactorClient> client = createReactorClient(uri); Line 40: return new FutureResultWrapper<>(client, tabs Line 41: new ResultWrapper<JsonRpcClient, ReactorClient>() { Line 42: @Override Line 43: public JsonRpcClient wrap(ReactorClient value) { Line 44: if (value == null) {
.................................................... File client/java/vdsm-api/src/main/java/org/ovirt/vdsm/VDSMObject.java Line 37: } Line 38: Line 39: @Override Line 40: public boolean equals(Object obj) { Line 41: if (this == obj) { tabs and redundant indentation Line 42: return true; Line 43: } Line 44: if ((obj == null) || (obj.getClass() != this.getClass())) { Line 45: return false;
.................................................... File client/java/vdsm-json-rpc/src/test/java/org/ovirt/vdsm/jsonrpc/TcpSSLReactorTestHelper.java Line 5: Line 6: public class TcpSSLReactorTestHelper implements ReactorTestHelper { Line 7: Line 8: public static final String KEYSTORE_PATH = Line 9: "/home/saggi/projects/vdsm/tests/jsonrpc-tests.p12"; is this path valid...? Line 10: Line 11: @Override Line 12: public Reactor createReactor(JsonRpcServer server) throws Exception { Line 13: return new NioReactor(server.createSSLContext());
.................................................... File lib/yajsonrpc/__init__.py Line 88 Line 89 Line 90 Line 91 Line 92 why removing it?
Line 449: self._workQueue = Queue() Line 450: self._threadFactory = threadFactory Line 451: Line 452: def queueRequest(self, req): Line 453: print "DSAD" debug Line 454: self._workQueue.put_nowait(req) Line 455: print "DSAD" Line 456: Line 457: def _serveRequest(self, ctx, req):
vdsm-patches@lists.fedorahosted.org