Francesco Romani has posted comments on this change.
Change subject: network: switch to concurrent.thread()
......................................................................
Patch Set 9:
(2 comments)
https://gerrit.ovirt.org/#/c/61459/9/lib/vdsm/network/configurators/ifcfg.py
File lib/vdsm/network/configurators/ifcfg.py:
Line 861: if not iface.blockingdhcp and (iface.ipv4.bootproto == 'dhcp' or
Line 862: iface.ipv6.dhcpv6):
Line 863: # wait for dhcp in another thread, so vdsm won't get stuck
(BZ#498940)
Line 864: t = concurrent.thread(_exec_ifup,
Line 865: name='ifup-waiting-on-dhcp',
In another patch we should shorten this name (ifup-dhcp?)
ifup-dhcp seems nice to me, let's see what network devs like.
Line 866: args=(iface, cgroup))
Line 867: t.start()
Line 868: else:
Line 869: if not iface.master and (iface.ipv4 or iface.ipv6):
https://gerrit.ovirt.org/#/c/61459/9/lib/vdsm/network/ip/dhclient.py
File lib/vdsm/network/ip/dhclient.py:
Line 73: if blocking:
Line 74: return self._dhclient()
Line 75: else:
Line 76: t = concurrent.thread(self._dhclient,
Line 77: name='vdsm-dhclient-%s' % self.iface)
The last part will be truncated in htop/ps, better remove vdsm from
the nam
Looks nice to me, I'm a bit more confident about this one, so fixing in
another patch.
Line 78: t.start()
Line 79:
Line 80: def shutdown(self):
Line 81: try:
--
To view, visit
https://gerrit.ovirt.org/61459
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7918a6762b35000b02187a0356273e40bba57a8
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes