Dan Kenigsberg has uploaded a new change for review.
Change subject: xen: do not attempt to read underlying device info ......................................................................
xen: do not attempt to read underlying device info
Xen's device information is quite different than what Vdsm currently expects and needs. They lack bus address, alias, and driver. With this patch, Vdsm-on-Xen does not even attempt to read this information, which means that it would not be able to inract with the underlying devices.
This is a hack which I do not expect getting into Vdsm proper. Much deeper refactoring is required to handle Xen devices.
Change-Id: Ifae785c5caa2e37fb8968ead570502e935f7900f Signed-off-by: Dan Kenigsberg danken@redhat.com --- M vdsm/virt/vm.py 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/28352/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index 21662bc..6a0d035 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -2921,7 +2921,8 @@ raise Exception('destroy() called before Vm started')
self._getUnderlyingVmInfo() - self._getUnderlyingVmDevicesInfo() + if not libvirtconnection.XEN: + self._getUnderlyingVmDevicesInfo() self._updateAgentChannels()
# Currently there is no protection agains mirroring a network twice,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: xen: do not attempt to read underlying device info ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9688/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8755/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9541/ : SUCCESS
Itamar Heim has posted comments on this change.
Change subject: xen: do not attempt to read underlying device info ......................................................................
Patch Set 1:
ping
Jenkins CI RO has posted comments on this change.
Change subject: xen: do not attempt to read underlying device info ......................................................................
Patch Set 1:
Abandoned due to no activity - please restore if still relevant
Jenkins CI RO has abandoned this change.
Change subject: xen: do not attempt to read underlying device info ......................................................................
Abandoned
Abandoned due to no activity - please restore if still relevant
automation@ovirt.org has posted comments on this change.
Change subject: xen: do not attempt to read underlying device info ......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
vdsm-patches@lists.fedorahosted.org