Change in vdsm[master]: BindingXMLRPC: Check irs init status

Adam Litke has uploaded a new change for review.

Change subject: BindingXMLRPC: Check irs init status
......................................................................

BindingXMLRPC: Check irs init status

During vdsm initialization, it is possible that IRS will fail to initialize and
will instead be None.  During API refactoring we added a TODO to the code to
re-enable checking for this case.  In this patch, we check if cif.irs is None
and if so, activate a default storage error message for all storage methods.

Change-Id: I87b1509f4cb95319d0a88cec75f941d61aa5dae5
Signed-off-by: Adam Litke 
---
M vdsm/BindingXMLRPC.py
1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/3571/1
--
To view, visit http://gerrit.ovirt.org/3571
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I87b1509f4cb95319d0a88cec75f941d61aa5dae5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BindingXMLRPC: Check irs init status
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

breaks a couple of abstraction layers, but keeps former behaviour.

--
To view, visit http://gerrit.ovirt.org/3571
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87b1509f4cb95319d0a88cec75f941d61aa5dae5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg

Saggi Mizrahi has posted comments on this change.

Change subject: BindingXMLRPC: Check irs init status
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3571
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87b1509f4cb95319d0a88cec75f941d61aa5dae5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: BindingXMLRPC: Check irs init status
......................................................................

BindingXMLRPC: Check irs init status

During vdsm initialization, it is possible that IRS will fail to initialize and
will instead be None.  During API refactoring we added a TODO to the code to
re-enable checking for this case.  In this patch, we check if cif.irs is None
and if so, activate a default storage error message for all storage methods.

Change-Id: I87b1509f4cb95319d0a88cec75f941d61aa5dae5
Signed-off-by: Adam Litke 
---
M vdsm/BindingXMLRPC.py
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Saggi Mizrahi: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3571
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I87b1509f4cb95319d0a88cec75f941d61aa5dae5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BindingXMLRPC: Check irs init status
......................................................................

Patch Set 1: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3571
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87b1509f4cb95319d0a88cec75f941d61aa5dae5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Saggi Mizrahi