Change in vdsm[master]: ovs: early IP+link setup

Edward Haas has posted comments on this change.

Change subject: ovs: early IP+link setup
......................................................................


Patch Set 4:

(5 comments)

https://gerrit.ovirt.org/#/c/60371/4/configure.ac
File configure.ac:

PS4, Line 169: OVS_NET_SERVICE
I do not think this needs to change at all, only the OPENVSWITCHSERVICE requirement needs
to be placed in the vdsm-network-init service.


https://gerrit.ovirt.org/#/c/60371/4/init/systemd/vdsm-network-ovs-init.s...
File init/systemd/vdsm-network-ovs-init.service.in:

I think that 'ovs' can be dropped from the file name and description.
Currently, internal implementation will cover only ovs typed networks, later on we will
probably want to use it for legacy as well.
Line 1: [Unit]
Line 2: Description=Virtual Desktop Server Manager OVS network IP+link restoration
Line 3: Wants=network.target
Line 4: Requires=openvswitch.service


Line 1: [Unit]
Line 2: Description=Virtual Desktop Server Manager OVS network IP+link restoration
Line 3: Wants=network.target
Line 4: Requires=openvswitch.service
Line 5: After=openvswitch.service
We need it Before libvirt as well.
We may want it Before network manager, not sure.
Line 6: 
Line 7: [Service]
Line 8: Type=oneshot
Line 9: EnvironmentFile=-/etc/sysconfig/vdsm


https://gerrit.ovirt.org/#/c/60371/4/init/systemd/vdsm-network.service.in
File init/systemd/vdsm-network.service.in:

PS4, Line 4: @OVS_NET_SERVICE@
Original just needs to be moved to vdsm-network-init and here depend (always) on 
vdsm-network-init


https://gerrit.ovirt.org/#/c/60371/4/lib/vdsm/tool/restore_ovs_nets.py
File lib/vdsm/tool/restore_ovs_nets.py:

PS4, Line 44: _NETS_RESTORED_MARK
Who creates it?


-- 
To view, visit https://gerrit.ovirt.org/60371
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0555a61c9709be54bfb2587e3020d3046db10ec6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: Yes