Change in vdsm[master]: tests: add unit tests for IOProcess per SD

Yeela Kaplan has uploaded a new change for review.

Change subject: tests: add unit tests for IOProcess per SD
......................................................................

tests: add unit tests for IOProcess per SD

Change-Id: I904a33e45ad935856517b70f6bd3e6e5d56ca187
Signed-off-by: Yeela Kaplan <ykaplan(a)redhat.com&gt;
---
M tests/outOfProcessTests.py
1 file changed, 48 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/34578/1

diff --git a/tests/outOfProcessTests.py b/tests/outOfProcessTests.py
index e49930f..94918a0 100644
--- a/tests/outOfProcessTests.py
+++ b/tests/outOfProcessTests.py
@@ -22,13 +22,61 @@
 import storage.outOfProcess as oop
 import os
 import tempfile
+import time
+import re
+from weakref import ref
+
+from vdsm.config import config
 
 
 class OopWrapperTests(TestCaseBase):
+    IOPROC_IDLE_TIME = config.getint("irs",
"max_ioprocess_idle_time")
+
     def setUp(self):
         oop.setDefaultImpl(oop.IOPROC)
         self.pool = oop.getGlobalProcPool()
 
+    def testSamePoolName(self):
+        poolA = "A"
+        pids = []
+        for pool in (poolA, poolA):
+            proc = oop.getProcessPool(pool)._ioproc
+            name = proc._commthread.getName()
+            pids.append(int(re.search(r'\d+', name).group()))
+
+        self.assertEquals(pids[0], pids[1])
+
+    def testDifferentPoolName(self):
+        poolA = "A"
+        poolB = "B"
+        pools = (poolA, poolB)
+        pids = []
+        for pool in pools:
+            proc = oop.getProcessPool(pool)._ioproc
+            name = proc._commthread.name
+            pids.append(int(re.search(r'\d+', name).group()))
+
+        self.assertNotEquals(pids[0], pids[1])
+
+    def testAmountOfInstancesPerPoolName(self):
+        poolA = "A"
+        poolB = "B"
+        wrapper = ref(oop.getProcessPool(poolA))
+        ioproc = ref(oop.getProcessPool(poolA)._ioproc)
+        oop.getProcessPool(poolA)
+        time.sleep(self.IOPROC_IDLE_TIME + 1)
+        oop.getProcessPool(poolB)
+        self.assertEquals(wrapper(), None)
+        import gc
+        gc.collect()
+        time.sleep(1)
+        gc.collect()
+        print "GARBAGE: ", gc.garbage
+        refs = gc.get_referrers(ioproc())
+        print refs
+        print gc.get_referrers(*refs)
+        self.assertEquals(ioproc(), None)
+
     def testEcho(self):
         data = """Censorship always defeats it own purpose, for it creates
in
                   the end the kind of society that is incapable of exercising


-- 
To view, visit http://gerrit.ovirt.org/34578
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I904a33e45ad935856517b70f6bd3e6e5d56ca187
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: add unit tests for IOProcess per SD
......................................................................


Patch Set 2:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/152/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/175/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/368/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6000/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/173/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/168/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4161/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/34578
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I904a33e45ad935856517b70f6bd3e6e5d56ca187
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: add unit tests for IOProcess per SD
......................................................................


tests: add unit tests for IOProcess per SD

Change-Id: I904a33e45ad935856517b70f6bd3e6e5d56ca187
Signed-off-by: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/34578
Reviewed-by: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
---
M tests/outOfProcessTests.py
1 file changed, 48 insertions(+), 0 deletions(-)

Approvals:
  Yeela Kaplan: Verified
  Saggi Mizrahi: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/34578
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I904a33e45ad935856517b70f6bd3e6e5d56ca187
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server

Yeela Kaplan has posted comments on this change.

Change subject: tests: add unit tests for IOProcess per SD
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/34578
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I904a33e45ad935856517b70f6bd3e6e5d56ca187
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Saggi Mizrahi has posted comments on this change.

Change subject: tests: add unit tests for IOProcess per SD
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/34578
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I904a33e45ad935856517b70f6bd3e6e5d56ca187
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: add unit tests for IOProcess per SD
......................................................................


Patch Set 1:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13244/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13084/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12294/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/34578
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I904a33e45ad935856517b70f6bd3e6e5d56ca187
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No