Change in vdsm[master]: Change vmchannel name to remove rhevm

[Ryan Harper]

Ryan Harper has uploaded a new change for review.

Change subject: Change vmchannel name to remove rhevm
......................................................................

Change vmchannel name to remove rhevm

Change-Id: I95b44512052bdb5fed8c8c1486eafc41b85b5f13
Signed-off-by: Ryan Harper 
---
M vdsm/libvirtvm.py
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/3288/1
--
To view, visit http://gerrit.ovirt.org/3288
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I95b44512052bdb5fed8c8c1486eafc41b85b5f13
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper

Adam Litke has posted comments on this change.

Change subject: Change vmchannel name to remove rhevm
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3288
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b44512052bdb5fed8c8c1486eafc41b85b5f13
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper 
Gerrit-Reviewer: Adam Litke

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Change vmchannel name to remove rhevm
......................................................................

Patch Set 1: (1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 41: _VMCHANNEL_DEVICE_NAME = 'com.redhat.ovirt.vdsm'
we would have a compatibility issue here, with rhev-guest-agent.

I would appreciate if you can think of a way to allow sane support of both rhev and ovirt strings in API-affecting places.

--
To view, visit http://gerrit.ovirt.org/3288
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b44512052bdb5fed8c8c1486eafc41b85b5f13
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Change vmchannel name to remove rhevm
......................................................................

Patch Set 1: I would prefer that you didn't submit this

Actually, I think http://gerrit.ovirt.org/1146 is better (but not good enough, due to the compatibility issue we have).

--
To view, visit http://gerrit.ovirt.org/3288
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b44512052bdb5fed8c8c1486eafc41b85b5f13
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg

[Ryan Harper]

Ryan Harper has abandoned this change.

Change subject: Change vmchannel name to remove rhevm
......................................................................

Patch Set 1: Abandoned

Too Old

--
To view, visit http://gerrit.ovirt.org/3288
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I95b44512052bdb5fed8c8c1486eafc41b85b5f13
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: oVirt Jenkins CI Server