Yeela Kaplan has uploaded a new change for review.
Change subject: clientIF: return doneCode in getDiskAlignment ......................................................................
clientIF: return doneCode in getDiskAlignment
Engine expects a dictionary instead of an integer(0)
Change-Id: I9effa0c05b711cd2f1983009f92819cb315ec9f0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=998411 Signed-off-by: Yeela Kaplan ykaplan@redhat.com --- M vdsm/clientIF.py 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/18737/1
diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py index c2a25fc..38822fe 100644 --- a/vdsm/clientIF.py +++ b/vdsm/clientIF.py @@ -382,7 +382,7 @@ finally: self.teardownVolumePath(drive)
- return {'status': 0, 'alignment': aligning} + return {'status': doneCode, 'alignment': aligning}
def createVm(self, vmParams): with self.vmContainerLock:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: return doneCode in getDiskAlignment ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4236/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3341/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4157/ : SUCCESS
Sergey Gotliv has posted comments on this change.
Change subject: clientIF: return doneCode in getDiskAlignment ......................................................................
Patch Set 1: Verified+1 Code-Review+1
Dan Kenigsberg has posted comments on this change.
Change subject: clientIF: return doneCode in getDiskAlignment ......................................................................
Patch Set 1: Code-Review+2
We should have noticed this on first round...
Dan Kenigsberg has submitted this change and it was merged.
Change subject: clientIF: return doneCode in getDiskAlignment ......................................................................
clientIF: return doneCode in getDiskAlignment
Engine expects a dictionary instead of an integer(0)
Change-Id: I9effa0c05b711cd2f1983009f92819cb315ec9f0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=998411 Signed-off-by: Yeela Kaplan ykaplan@redhat.com Reviewed-on: http://gerrit.ovirt.org/18737 Reviewed-by: Sergey Gotliv sgotliv@redhat.com Tested-by: Sergey Gotliv sgotliv@redhat.com Reviewed-by: Dan Kenigsberg danken@redhat.com --- M vdsm/clientIF.py 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Sergey Gotliv: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved
vdsm-patches@lists.fedorahosted.org