Change in vdsm[master]: tests: Honour PYTHONPATH if set on the host

Deepak C Shetty has uploaded a new change for review.

Change subject: tests: Honour PYTHONPATH if set on the host
......................................................................

tests: Honour PYTHONPATH if set on the host

run_tests_local.sh doesn't honour PYTHONPATH if it was set.
This causes issues with the tests (sometimes) if user was using
a custom path for say libvirt ( running from a git src, rather
than installed rpm path). This path add $PYTHONPATH to the
script to fix the issue.

Change-Id: Ia4a3ac4d238da59abf558b628fa34cae90006b6e
Signed-off-by: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
---
M tests/run_tests_local.sh.in
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/7648/1

diff --git a/tests/run_tests_local.sh.in b/tests/run_tests_local.sh.in
index c4bc5c8..bb43538 100644
--- a/tests/run_tests_local.sh.in
+++ b/tests/run_tests_local.sh.in
@@ -1,2 +1,2 @@
 #!/bin/sh
-PYTHONDONTWRITEBYTECODE=1 LC_ALL=C
PYTHONPATH="@builddir@/vdsm:@top_srcdir@/vdsm:@top_srcdir@/vdsm_cli" @PYTHON@
@top_srcdir(a)/tests/testrunner.py --local-modules $@
+PYTHONDONTWRITEBYTECODE=1 LC_ALL=C
PYTHONPATH="$PYTHONPATH:@builddir@/vdsm:@top_srcdir@/vdsm:@top_srcdir@/vdsm_cli"
@PYTHON@ @top_srcdir(a)/tests/testrunner.py --local-modules $@


--
To view, visit http://gerrit.ovirt.org/7648
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4a3ac4d238da59abf558b628fa34cae90006b6e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: Honour PYTHONPATH if set on the host
......................................................................


tests: Honour PYTHONPATH if set on the host

run_tests_local.sh doesn't honour PYTHONPATH if it was set.
This causes issues with the tests (sometimes) if user was using
a custom path for say libvirt ( running from a git src, rather
than installed rpm path). This path add $PYTHONPATH to the
script to fix the issue.

Change-Id: Ia4a3ac4d238da59abf558b628fa34cae90006b6e
Signed-off-by: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
---
M tests/run_tests_local.sh.in
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Deepak C Shetty: Verified


--
To view, visit http://gerrit.ovirt.org/7648
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia4a3ac4d238da59abf558b628fa34cae90006b6e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: tests: Honour PYTHONPATH if set on the host
......................................................................


Patch Set 2: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/7648
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4a3ac4d238da59abf558b628fa34cae90006b6e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Deepak C Shetty has posted comments on this change.

Change subject: tests: Honour PYTHONPATH if set on the host
......................................................................


Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/7648
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4a3ac4d238da59abf558b628fa34cae90006b6e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: tests: Honour PYTHONPATH if set on the host
......................................................................


Patch Set 1: I would prefer that you didn't submit this

I think it would be safer to put "our" paths first, so we are sure that we test
our own code, and not something hining elsewhere in the search path.

--
To view, visit http://gerrit.ovirt.org/7648
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4a3ac4d238da59abf558b628fa34cae90006b6e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: Honour PYTHONPATH if set on the host
......................................................................


Patch Set 1:

Build Successful 

http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/787/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/7648
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4a3ac4d238da59abf558b628fa34cae90006b6e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server