Change in vdsm[master]: Add checks in configure for required python modules

Ewoud Kohl van Wijngaarden has uploaded a new change for review.

Change subject: Add checks in configure for required python modules
......................................................................

Add checks in configure for required python modules

The ax_python_module comes (unmodified) from the GNU autoconf archive.

Change-Id: I863af49e5e2be644e9a5a337f57455bc4088be6b
---
M configure.ac
A m4/ax_python_module.m4
2 files changed, 55 insertions(+), 0 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/3411/1
--
To view, visit http://gerrit.ovirt.org/3411
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I863af49e5e2be644e9a5a337f57455bc4088be6b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Add checks in configure for required python modules
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

hmm, we need the in build time only for the testing, right? I can live with that, since I want everybody to run the unit tests.

If this is so, please note that in the commit message.

--
To view, visit http://gerrit.ovirt.org/3411
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I863af49e5e2be644e9a5a337f57455bc4088be6b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Dan Kenigsberg

Change in vdsm[master]: Add build time checks for required python modules

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Add build time checks for required python modules
......................................................................

Patch Set 2:

I don't think I've got a clear answer: in general, we would not have needed these packages during build time, right?
And we only need them for unit-testing?

--
To view, visit http://gerrit.ovirt.org/3411
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I863af49e5e2be644e9a5a337f57455bc4088be6b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden

Change in vdsm[master]: Add build time checks for required python modules

Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: Add build time checks for required python modules
......................................................................

Patch Set 2:

Ah yes. I indeed did ran into the issue that I didn't have libvirt and ethtool installed which made make check fail. Since we already have python-nose as hard dependency in configure.ac I added these checks as unconditional as well.

--
To view, visit http://gerrit.ovirt.org/3411
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I863af49e5e2be644e9a5a337f57455bc4088be6b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden

Change in vdsm[master]: Add build time checks for required python modules

Saggi Mizrahi has posted comments on this change.

Change subject: Add build time checks for required python modules
......................................................................

Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3411
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I863af49e5e2be644e9a5a337f57455bc4088be6b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Add build time checks for required python modules

Saggi Mizrahi has posted comments on this change.

Change subject: Add build time checks for required python modules
......................................................................

Patch Set 2:

Could it also potentially support reading __version__ and checking that as well?

--
To view, visit http://gerrit.ovirt.org/3411
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I863af49e5e2be644e9a5a337f57455bc4088be6b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Add build time checks for required python modules

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Add build time checks for required python modules
......................................................................

Patch Set 2: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3411
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I863af49e5e2be644e9a5a337f57455bc4088be6b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Add build time checks for required python modules

Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: Add build time checks for required python modules
......................................................................

Patch Set 2:

I'm not sure how consistently we can check on __version__ in python packages and how relevant it is given RHEL has features backported so I would prefer to add this in a separate patch.

--
To view, visit http://gerrit.ovirt.org/3411
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I863af49e5e2be644e9a5a337f57455bc4088be6b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Add build time checks for required python modules

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Add build time checks for required python modules
......................................................................

Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/3411
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I863af49e5e2be644e9a5a337f57455bc4088be6b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Add build time checks for required python modules

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Add build time checks for required python modules
......................................................................

Add build time checks for required python modules

With these checks configure will fail if required python modules can't
be imported. The benefit is that it will fail faster, making it easier
to notice dependency changes for packagers.

The ax_python_module comes (unmodified) from the GNU autoconf archive.

Change-Id: I863af49e5e2be644e9a5a337f57455bc4088be6b
Signed-off-by: Ewoud Kohl van Wijngaarden 
---
M configure.ac
A m4/ax_python_module.m4
2 files changed, 55 insertions(+), 0 deletions(-)

Approvals:
  Saggi Mizrahi: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3411
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I863af49e5e2be644e9a5a337f57455bc4088be6b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Saggi Mizrahi