Change in vdsm[master]: Use more descriptive exceptions for blocksize errors.

Lee Yarwood has uploaded a new change for review.

Change subject: Use more descriptive exceptions for blocksize errors.
......................................................................

Use more descriptive exceptions for blocksize errors.

DeviceLogicalBlockSizeError  - 518
DevicePhysicalBlockSizeError - 519

Change-Id: I1bdb9aa24a5efa5c919ace632dfaba8d96fc3c73
Signed-off-by: Lee Yarwood 
---
M AUTHORS
M vdsm/storage/lvm.py
M vdsm/storage/storage_exception.py
3 files changed, 13 insertions(+), 5 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/3688/1
--
To view, visit http://gerrit.ovirt.org/3688
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1bdb9aa24a5efa5c919ace632dfaba8d96fc3c73
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood

Lee Yarwood has posted comments on this change.

Change subject: Use more descriptive exceptions for blocksize errors.
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

Required by ovirt-engine change http://gerrit.ovirt.org/3696.

--
To view, visit http://gerrit.ovirt.org/3688
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1bdb9aa24a5efa5c919ace632dfaba8d96fc3c73
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood 
Gerrit-Reviewer: Lee Yarwood

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Use more descriptive exceptions for blocksize errors.
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

could you explain the motivation for this (and the compatible change in Engine)? wouldn't a text string reporting the phys and logical size do a better job?

....................................................
File vdsm/storage/lvm.py
Line 897:             raise se.DevicePhysicalBlockSizeError(pvBlkSize)
the name is more descriptive, but less exact. PhysicalBlockSize is not really "bad" here. It is its relative size to LogicalBlockSize that is bad...

--
To view, visit http://gerrit.ovirt.org/3688
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1bdb9aa24a5efa5c919ace632dfaba8d96fc3c73
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Lee Yarwood

Lee Yarwood has abandoned this change.

Change subject: Use more descriptive exceptions for blocksize errors.
......................................................................

Patch Set 1: Abandoned

--
To view, visit http://gerrit.ovirt.org/3688
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I1bdb9aa24a5efa5c919ace632dfaba8d96fc3c73
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Lee Yarwood