Change in vdsm[master]: Fix the new lv_name field for the new lvm lib.

Eduardo has uploaded a new change for review.

Change subject: Fix the new lv_name field for the new lvm lib.
......................................................................

Fix the new lv_name field for the new lvm lib.

This is a hotfix, more elegant version is comming.
The use of pv_name is fully intentional.

Change-Id: I988b72af48bc5024f410a0a4296d553d352c8440
---
M vdsm/storage/lvm.py
1 file changed, 5 insertions(+), 3 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/2952/1
--
To view, visit http://gerrit.ovirt.org/2952
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I988b72af48bc5024f410a0a4296d553d352c8440
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Fix the new lv_name field for the new lvm lib.
......................................................................

Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

If there's not an equivalent release for upstream (fedora) we might want to bring this downstream only. Marking -1 for visibility.

....................................................
Commit Message
Line 12: The reason for this fix is that in lvm >= 2.02.95 (RHEL 6.3),
Is there an equivalent upstream release? (fedora)

Please also add the requirements to the spec file (using the two different sections rhel/fedora).

--
To view, visit http://gerrit.ovirt.org/2952
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I988b72af48bc5024f410a0a4296d553d352c8440
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Barak Azulay 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky

Saggi Mizrahi has posted comments on this change.

Change subject: Fix the new lv_name field for the new lvm lib.
......................................................................

Patch Set 2: I would prefer that you didn't submit this

My patch fixes that and doesn't assume stupid things about how things are formatted is uses the canonical way that VDSM uses to get device guids. I'm annoyed as it is with all the weird formatting assumptions that lvmcache uses. Stop reimplementing logic, devicemapper.py and multipath.py are balanced for speed and correctness, use their abilities. Don't optimize more when you don't have to.

I don't want to start a stupid mine is bigger then yours war so I'd concede if I'm the only one that thinks that more shaky name mangling is NOT the solution.

--
To view, visit http://gerrit.ovirt.org/2952
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I988b72af48bc5024f410a0a4296d553d352c8440
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Barak Azulay 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Fix the new lv_name field for the new lvm lib.
......................................................................

Patch Set 2: I would prefer that you didn't submit this

Saggi, this patch is plain and simple and I do not understand why you mock it so badly.

Your "competing" patch http://gerrit.ovirt.org/2940 introduces more complexity and stuff we know we would like to remove.

A proper solution would not expect lvm.py to provide the devicemapper GUID of the LV.

--
To view, visit http://gerrit.ovirt.org/2952
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I988b72af48bc5024f410a0a4296d553d352c8440
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Barak Azulay 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Eduardo has abandoned this change.

Change subject: Fix the new lv_name field for the new lvm lib.
......................................................................

Patch Set 2: Abandoned

lvm was fixed.

--
To view, visit http://gerrit.ovirt.org/2952
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I988b72af48bc5024f410a0a4296d553d352c8440
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Barak Azulay 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi