7:30 a.m.
Dan Kenigsberg has uploaded a new change for review.
Change subject: BZ#729251 vds_bootstrap: drop dead netconsole/vdcrepo code
......................................................................
BZ#729251 vds_bootstrap: drop dead netconsole/vdcrepo code
When http://gerrit.ovirt.org/1848 and http://gerrit.ovirt.org/1689 are taken
into Engine, -u and -n options to vds_bootrap would never be passed.
Remove this dead code.
Change-Id: I528103d344b2a9d0bee87e3c68e32b2d67ab439a
---
M vds_bootstrap/vds_bootstrap.py
M vdsm.spec.in
2 files changed, 9 insertions(+), 38 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/1931/1
--
To view, visit http://gerrit.ovirt.org/1931
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I528103d344b2a9d0bee87e3c68e32b2d67ab439a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
2:13 p.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#729251 vds_bootstrap: drop dead netconsole/vdcrepo code
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1931
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I528103d344b2a9d0bee87e3c68e32b2d67ab439a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
6:10 p.m.
Saggi Mizrahi has posted comments on this change.
Change subject: BZ#729251 vds_bootstrap: drop dead netconsole/vdcrepo code
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1931
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I528103d344b2a9d0bee87e3c68e32b2d67ab439a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
10:44 a.m.
Igor Lvovsky has submitted this change and it was merged.
Change subject: BZ#729251 vds_bootstrap: drop dead netconsole/vdcrepo code
......................................................................
BZ#729251 vds_bootstrap: drop dead netconsole/vdcrepo code
When http://gerrit.ovirt.org/1848 and http://gerrit.ovirt.org/1689 are taken
into Engine, -u and -n options to vds_bootrap would never be passed.
Remove this dead code.
Change-Id: I528103d344b2a9d0bee87e3c68e32b2d67ab439a
---
M vds_bootstrap/vds_bootstrap.py
M vdsm.spec.in
2 files changed, 9 insertions(+), 38 deletions(-)
Approvals:
Igor Lvovsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1931
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I528103d344b2a9d0bee87e3c68e32b2d67ab439a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
10:44 a.m.
Igor Lvovsky has posted comments on this change.
Change subject: BZ#729251 vds_bootstrap: drop dead netconsole/vdcrepo code
......................................................................
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1931
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I528103d344b2a9d0bee87e3c68e32b2d67ab439a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
10:40 a.m.
Igor Lvovsky has posted comments on this change.
Change subject: BZ#729251 vds_bootstrap: drop dead netconsole/vdcrepo code
......................................................................
Patch Set 2: Verified; Looks good to me, approved
Verified by Haim
--
To view, visit http://gerrit.ovirt.org/1931
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I528103d344b2a9d0bee87e3c68e32b2d67ab439a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
2:17 a.m.
Igor Lvovsky has posted comments on this change.
Change subject: BZ#729251 vds_bootstrap: drop dead netconsole/vdcrepo code
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1931
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I528103d344b2a9d0bee87e3c68e32b2d67ab439a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4418
days inactive
4447
days old
vdsm-patches@lists.fedorahosted.org
6 comments
4 participants
participants (4)
-
Dan Kenigsberg -
Douglas Schilling Landgraf -
Igor Lvovsky -
smizrahi＠redhat.com