Change in vdsm[master]: [WIP] Don't waste SD produces in validateSdUUID.

Eduardo has uploaded a new change for review.

Change subject: [WIP] Don't waste SD produces in validateSdUUID.
......................................................................

[WIP] Don't waste SD produces in validateSdUUID.

TODO:
Change all validateSdUUID callers to pass the produced domain.
Consider removing this function. If not rename it.

Change-Id: Ic9caea51dec6063c978cad3f9403628e15062582
Signed-off-by: Eduardo 
---
M vdsm/storage/hsm.py
1 file changed, 7 insertions(+), 5 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/3465/1
--
To view, visit http://gerrit.ovirt.org/3465
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9caea51dec6063c978cad3f9403628e15062582
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: [WIP] Don't waste SD produces in validateSdUUID.
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(3 inline comments)

You did it well, just finish the job if started it :)

....................................................
File vdsm/storage/hsm.py
Line 1304:         if not sdCache.produce(dstDomUUID).isBackup():
what about this one?

Line 1337:         if not sdCache.produce(dstDomUUID).isBackup():
and this one

Line 2216:         dom = sdCache.produce(sdUUID=sdUUID)
same here

--
To view, visit http://gerrit.ovirt.org/3465
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9caea51dec6063c978cad3f9403628e15062582
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: [WIP] Don't waste SD produces in validateSdUUID.
......................................................................

Patch Set 3: I would prefer that you didn't submit this

Look at my comments for patchset 1

--
To view, visit http://gerrit.ovirt.org/3465
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9caea51dec6063c978cad3f9403628e15062582
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky

Eduardo has posted comments on this change.

Change subject: [WIP] Don't waste SD produces in validateSdUUID.
......................................................................

Patch Set 4: I would prefer that you didn't submit this

This is a clean up commit.
PLEASE IGNORE

--
To view, visit http://gerrit.ovirt.org/3465
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9caea51dec6063c978cad3f9403628e15062582
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: [WIP] Don't waste SD produces in validateSdUUID.
......................................................................

Patch Set 5: I would prefer that you didn't submit this

(2 inline comments)

If you started to do it, please do it in all proper places.

....................................................
File vdsm/storage/hsm.py
Line 1304:         if not sdCache.produce(dstDomUUID).isBackup():
what about this one?

Line 1337:         if not sdCache.produce(dstDomUUID).isBackup():
what about this one?

--
To view, visit http://gerrit.ovirt.org/3465
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9caea51dec6063c978cad3f9403628e15062582
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky

Change in vdsm[master]: [WIP] BZ#788640 - Don't waste SD produces in validateSdUUID.

Ayal Baron has posted comments on this change.

Change subject: [WIP] BZ#788640 - Don't waste SD produces in validateSdUUID.
......................................................................

Patch Set 6: Looks good to me, but someone else must approve

(1 inline comment)

Please see inline comment.

....................................................
File vdsm/storage/hsm.py
Line 775:                 dom = sdCache.produce(sdUUID=sdUUID)
can change this with validateSdUUID

--
To view, visit http://gerrit.ovirt.org/3465
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9caea51dec6063c978cad3f9403628e15062582
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky

Change in vdsm[master]: [WIP] BZ#788640 - Don't waste SD produces in validateSdUUID.

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: [WIP] BZ#788640 - Don't waste SD produces in validateSdUUID.
......................................................................

Patch Set 6: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3465
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9caea51dec6063c978cad3f9403628e15062582
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky

Change in vdsm[master]: [WIP] BZ#788640 - Don't waste SD produces in validateSdUUID.

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: [WIP] BZ#788640 - Don't waste SD produces in validateSdUUID.
......................................................................

Patch Set 6:

remove the WIP

--
To view, visit http://gerrit.ovirt.org/3465
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9caea51dec6063c978cad3f9403628e15062582
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky

Change in vdsm[master]: BZ#788640 - Don't waste SD produces in validateSdUUID.

Ayal Baron has posted comments on this change.

Change subject: BZ#788640 - Don't waste SD produces in validateSdUUID.
......................................................................

Patch Set 7: I would prefer that you didn't submit this

(2 inline comments)

....................................................
Commit Message
Line 10: Consider removing this function. If not, rename it.
what is 'this' function?
why remove?
rename to what?

....................................................
File vdsm/storage/hsm.py
Line 209:         sdDom = sdCache.produce(sdUUID=sdUUID)
sdDom = storage domain domain?
what's wrong with dom?

--
To view, visit http://gerrit.ovirt.org/3465
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9caea51dec6063c978cad3f9403628e15062582
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky

Change in vdsm[master]: BZ#788640 - Don't waste SD produces in validateSdUUID.

Ayal Baron has posted comments on this change.

Change subject: BZ#788640 - Don't waste SD produces in validateSdUUID.
......................................................................

Patch Set 8: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3465
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9caea51dec6063c978cad3f9403628e15062582
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky

Change in vdsm[master]: BZ#788640 - Don't waste SD produces in validateSdUUID.

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: BZ#788640 - Don't waste SD produces in validateSdUUID.
......................................................................

Patch Set 8: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3465
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9caea51dec6063c978cad3f9403628e15062582
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky

Change in vdsm[master]: BZ#788640 - Don't waste SD produces in validateSdUUID.

Ayal Baron has posted comments on this change.

Change subject: BZ#788640 - Don't waste SD produces in validateSdUUID.
......................................................................

Patch Set 8: (1 inline comment)

Please get someone to verify

....................................................
File vdsm/storage/hsm.py
Line 209:         sdDom = sdCache.produce(sdUUID=sdUUID)
still sdDom instead of dom all over?

--
To view, visit http://gerrit.ovirt.org/3465
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9caea51dec6063c978cad3f9403628e15062582
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Haim Ateya 
Gerrit-Reviewer: Igor Lvovsky

Change in vdsm[master]: BZ#788640 - Don't waste SD produces in validateSdUUID.

[Haim Ateya]

Haim Ateya has posted comments on this change.

Change subject: BZ#788640 - Don't waste SD produces in validateSdUUID.
......................................................................

Patch Set 8: Verified

tested extensively on both block & file domains running most of the core scenarios: copy, move, delete, import, export volumes\images.

--
To view, visit http://gerrit.ovirt.org/3465
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9caea51dec6063c978cad3f9403628e15062582
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Haim Ateya 
Gerrit-Reviewer: Igor Lvovsky

Change in vdsm[master]: BZ#788640 - Don't waste SD produces in validateSdUUID.

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#788640 - Don't waste SD produces in validateSdUUID.
......................................................................

BZ#788640 - Don't waste SD produces in validateSdUUID.

Change-Id: Ic9caea51dec6063c978cad3f9403628e15062582
Signed-off-by: Eduardo 
---
M vdsm/storage/hsm.py
1 file changed, 8 insertions(+), 7 deletions(-)

Approvals:
  Ayal Baron: Looks good to me, approved
  Haim Ateya: Verified
  Dan Kenigsberg: 
  Igor Lvovsky: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3465
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9caea51dec6063c978cad3f9403628e15062582
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Haim Ateya 
Gerrit-Reviewer: Igor Lvovsky