6:45 a.m.
mooli tayer has uploaded a new change for review.
Change subject: Remove verbosity from restorecon hack for /var/log/core.
......................................................................
Remove verbosity from restorecon hack for /var/log/core.
vebosity spams consoel during installation.
Change-Id: I862039a6dfeebe38fc5c62276ae98213ef92bd02
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1031109
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/21888/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index f248b74..af0a552 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -664,7 +664,7 @@
if /usr/sbin/selinuxenabled; then
/usr/sbin/semanage fcontext -a -t virt_cache_t '/var/log/core(/.*)?'
fi
-/sbin/restorecon -R -v /var/log/core
+/sbin/restorecon -R /var/log/core
# hack until we replace core dump with abrt
%if 0%{?rhel}
--
To view, visit http://gerrit.ovirt.org/21888
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I862039a6dfeebe38fc5c62276ae98213ef92bd02
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
1:49 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Remove verbosity from restorecon hack for /var/log/core.
......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/79/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/21888
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I862039a6dfeebe38fc5c62276ae98213ef92bd02
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:44 a.m.
mooli tayer has posted comments on this change.
Change subject: Remove verbosity from restorecon hack for /var/log/core.
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/21888
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I862039a6dfeebe38fc5c62276ae98213ef92bd02
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-HasComments: No
10:29 a.m.
mooli tayer has posted comments on this change.
Change subject: Remove verbosity from restorecon hack for /var/log/core.
......................................................................
Patch Set 2:
Trying to verify I keep getting:
"sanlock service requires restart" from vdsm-tool
--
To view, visit http://gerrit.ovirt.org/21888
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I862039a6dfeebe38fc5c62276ae98213ef92bd02
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:02 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Remove verbosity from restorecon hack for /var/log/core.
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5842/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5934/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5046/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/67/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/21888
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I862039a6dfeebe38fc5c62276ae98213ef92bd02
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9:59 a.m.
mooli tayer has posted comments on this change.
Change subject: Remove verbosity from restorecon hack for /var/log/core.
......................................................................
Patch Set 1:
(1 comment)
....................................................
File vdsm.spec.in
Line 663: # hack until we replace core dump with abrt
Line 664: if /usr/sbin/selinuxenabled; then
Line 665: /usr/sbin/semanage fcontext -a -t virt_cache_t
'/var/log/core(/.*)?'
Line 666: fi
Line 667: /sbin/restorecon -R /var/log/core
Done
Line 668: # hack until we replace core dump with abrt
Line 669:
Line 670: %if 0%{?rhel}
Line 671: if [ "$1" -eq 1 ] ; then
--
To view, visit http://gerrit.ovirt.org/21888
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I862039a6dfeebe38fc5c62276ae98213ef92bd02
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
9:24 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove verbosity from restorecon hack for /var/log/core.
......................................................................
Patch Set 1:
(1 comment)
....................................................
File vdsm.spec.in
Line 663: # hack until we replace core dump with abrt
Line 664: if /usr/sbin/selinuxenabled; then
Line 665: /usr/sbin/semanage fcontext -a -t virt_cache_t
'/var/log/core(/.*)?'
Line 666: fi
Line 667: /sbin/restorecon -R /var/log/core
dont you need also >/dev/null 2>&1 on errors? rpm not suppose to verbose
anything
Line 668: # hack until we replace core dump with abrt
Line 669:
Line 670: %if 0%{?rhel}
Line 671: if [ "$1" -eq 1 ] ; then
--
To view, visit http://gerrit.ovirt.org/21888
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I862039a6dfeebe38fc5c62276ae98213ef92bd02
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
8:10 a.m.
Eli Mesika has posted comments on this change.
Change subject: Remove verbosity from restorecon hack for /var/log/core.
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21888
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I862039a6dfeebe38fc5c62276ae98213ef92bd02
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:20 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Remove verbosity from restorecon hack for /var/log/core.
......................................................................
Patch Set 1: -Verified
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5838/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5930/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5042/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/66/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/21888
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I862039a6dfeebe38fc5c62276ae98213ef92bd02
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
6:47 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Remove verbosity from restorecon hack for /var/log/core.
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5837/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5929/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5041/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/65/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/21888
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I862039a6dfeebe38fc5c62276ae98213ef92bd02
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:45 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove verbosity from restorecon hack for /var/log/core.
......................................................................
Patch Set 2:
run "vdsm-tool configure --force" and restart vdsmd . I'll submit patch to
suggest it with the exception
--
To view, visit http://gerrit.ovirt.org/21888
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I862039a6dfeebe38fc5c62276ae98213ef92bd02
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:13 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove verbosity from restorecon hack for /var/log/core.
......................................................................
Patch Set 2: Code-Review+1
please verify without core folder exist. thanks
--
To view, visit http://gerrit.ovirt.org/21888
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I862039a6dfeebe38fc5c62276ae98213ef92bd02
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:28 a.m.
mooli tayer has posted comments on this change.
Change subject: Remove verbosity from restorecon hack for /var/log/core.
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/21888
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I862039a6dfeebe38fc5c62276ae98213ef92bd02
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
1:46 p.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Remove verbosity from restorecon hack for /var/log/core.
......................................................................
Remove verbosity from restorecon hack for /var/log/core.
vebosity spams consoel during installation.
Change-Id: I862039a6dfeebe38fc5c62276ae98213ef92bd02
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1031109
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/21888
Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yaniv Bronhaim: Looks good to me, but someone else must approve
mooli tayer: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21888
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I862039a6dfeebe38fc5c62276ae98213ef92bd02
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
1:46 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Remove verbosity from restorecon hack for /var/log/core.
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21888
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I862039a6dfeebe38fc5c62276ae98213ef92bd02
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-HasComments: No
3794
days inactive
3796
days old
vdsm-patches@lists.fedorahosted.org
14 comments
5 participants
participants (5)
-
Dan Kenigsberg -
emesika＠redhat.com -
Jenkins CI RO -
mtayer＠redhat.com -
ybronhei＠redhat.com