Change in vdsm[master]: setupNetwork: release deleted network first

[Dan Kenigsberg]

Dan Kenigsberg has uploaded a new change for review.

Change subject: setupNetwork: release deleted network first
......................................................................

setupNetwork: release deleted network first

We may need their resources for newly requested networks.

Change-Id: I23f5feb0005fd6853793979dbfba84f89dd9c5fb
---
M vdsm/configNetwork.py
1 file changed, 8 insertions(+), 2 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/893/1
--
To view, visit http://gerrit.ovirt.org/893
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I23f5feb0005fd6853793979dbfba84f89dd9c5fb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: setupNetwork: release deleted network first
......................................................................

Patch Set 1:

mention BZ#771682

--
To view, visit http://gerrit.ovirt.org/893
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23f5feb0005fd6853793979dbfba84f89dd9c5fb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: setupNetwork: release deleted network first
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/893
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23f5feb0005fd6853793979dbfba84f89dd9c5fb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Rami Vaknin 
Gerrit-Reviewer: Shahar Havivi

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: setupNetwork: release deleted network first
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 821:                     del networks[networks]
it actually should be delnetworks[network]  not 'networks'

--
To view, visit http://gerrit.ovirt.org/893
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23f5feb0005fd6853793979dbfba84f89dd9c5fb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Rami Vaknin 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: setupNetwork: release deleted network first
......................................................................

Patch Set 1: (1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 822: 
No
it should be the networks, 
but can you delete an item while in the iterator?

--
To view, visit http://gerrit.ovirt.org/893
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23f5feb0005fd6853793979dbfba84f89dd9c5fb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Rami Vaknin 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Shahar Havivi

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: setupNetwork: release deleted network first
......................................................................

Patch Set 2: Looks good to me, but someone else must approve

(1 inline comment)

I hope you verified it.

....................................................
File vdsm/configNetwork.py
Line 845:                     logger.debug('Removing network %r'%network)
space is a good thing  :)

--
To view, visit http://gerrit.ovirt.org/893
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23f5feb0005fd6853793979dbfba84f89dd9c5fb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Rami Vaknin 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: setupNetwork: release deleted network first
......................................................................

Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/893
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23f5feb0005fd6853793979dbfba84f89dd9c5fb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Rami Vaknin 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Shahar Havivi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: setupNetwork: release deleted network first
......................................................................

Patch Set 2: (1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 845:                     logger.debug('Removing network %r'%network)
Try to tell that to Erez...

--
To view, visit http://gerrit.ovirt.org/893
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23f5feb0005fd6853793979dbfba84f89dd9c5fb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Rami Vaknin 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Shahar Havivi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: setupNetwork: release deleted network first
......................................................................

Patch Set 2: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/893
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23f5feb0005fd6853793979dbfba84f89dd9c5fb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Rami Vaknin 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Shahar Havivi

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: setupNetwork: release deleted network first
......................................................................

setupNetwork: release deleted network first

We may need their resources for newly requested networks.

Change-Id: I23f5feb0005fd6853793979dbfba84f89dd9c5fb
---
M vdsm/configNetwork.py
1 file changed, 8 insertions(+), 2 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved
  Igor Lvovsky: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/893
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I23f5feb0005fd6853793979dbfba84f89dd9c5fb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Rami Vaknin 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Shahar Havivi