From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Fix store net config - delete dir correctly.
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/76603/1/lib/vdsm/network/netconfpersistence.py
File lib/vdsm/network/netconfpersistence.py:
Line 277: os.symlink(new_safeconf_dir, new_safeconf_symlink)
Line 278:
Line 279: real_old_safeconf_dir = os.path.realpath(safeconf_dir)
Line 280: os.rename(new_safeconf_symlink, safeconf_dir)
Line 281: utils.rmTree(real_old_safeconf_dir)
If there are leftovers in the directory (non current netconf dirs),
we are
netconf.NNNNNN are left behind if a host crashes before setSafe. We must not
remove old ones here, they should be kept for forensics. I suppose we should add a
logrotate rule to prune them after some time.
--
To view, visit
https://gerrit.ovirt.org/76603
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9ad4e4f40ffa7b65cb96006999d7b0a89419d59
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Michael Burman <mburman(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes