Change in vdsm[master]: jsonrpc: shorten executor thread' system names

Francesco Romani has uploaded a new change for review.

Change subject: jsonrpc: shorten executor thread' system  names
......................................................................

jsonrpc: shorten executor thread' system  names

We shorten the basename of the jsonrpc executor,
because the system has a hard limit of 15 ASCII
character per thread name.

The new name is less expressive, but leaves room
for the worker ID, which is an overall usability
improvement.

Before, it looked like

jsonrpc.Executo

now it looks like

jsonrpcex/0

Change-Id: Ibefc7d2c60d7b5d23739b129088f8e7f80514540
Signed-off-by: Francesco Romani 
---
M lib/vdsm/rpc/bindingjsonrpc.py
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/61978/1

diff --git a/lib/vdsm/rpc/bindingjsonrpc.py b/lib/vdsm/rpc/bindingjsonrpc.py
index 1f6f09a..1e55672 100644
--- a/lib/vdsm/rpc/bindingjsonrpc.py
+++ b/lib/vdsm/rpc/bindingjsonrpc.py
@@ -35,7 +35,7 @@
     log = logging.getLogger('BindingJsonRpc')

def __init__(self, bridge, subs, timeout, scheduler, cif):
-        self._executor = executor.Executor(name="jsonrpc.Executor",
+        self._executor = executor.Executor(name="jsonrpcex",
                                            workers_count=_THREADS,
                                            max_tasks=_TASKS,
                                            scheduler=scheduler)

gerrit-hooks has posted comments on this change.

Change subject: jsonrpc: shorten executor thread' system  names
......................................................................

Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])

gerrit-hooks has posted comments on this change.

Change subject: jsonrpc: shorten executor thread system names
......................................................................

Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])

gerrit-hooks has posted comments on this change.

Change subject: jsonrpc: shorten executor thread system names
......................................................................

Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])

gerrit-hooks has posted comments on this change.

Change subject: jsonrpc: shorten executor thread system names
......................................................................

Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])

gerrit-hooks has posted comments on this change.

Change subject: jsonrpc: shorten executor thread system names
......................................................................

Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])

gerrit-hooks has posted comments on this change.

Change subject: jsonrpc: shorten executor thread system names
......................................................................

Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: jsonrpc: shorten executor thread system names
......................................................................

Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/61978/6/lib/vdsm/rpc/bindingjsonrpc.py
File lib/vdsm/rpc/bindingjsonrpc.py:

Line 34: class BindingJsonRpc(object):
Line 35:     log = logging.getLogger('BindingJsonRpc')
Line 36: 
Line 37:     def __init__(self, bridge, subs, timeout, scheduler, cif):
Line 38:         self._executor = executor.Executor(name="jsonrpcex",
Do we need the "ex" suffix? The executor worker threads will be named jsonrpc/0 jsonrpc/1 ... - seems fine.
Line 39:                                            workers_count=_THREADS,
Line 40:                                            max_tasks=_TASKS,
Line 41:                                            scheduler=scheduler)
Line 42:         self._bridge = bridge

Francesco Romani has posted comments on this change.

Change subject: jsonrpc: shorten executor thread system names
......................................................................

Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/61978/6/lib/vdsm/rpc/bindingjsonrpc.py
File lib/vdsm/rpc/bindingjsonrpc.py:

Line 34: class BindingJsonRpc(object):
Line 35:     log = logging.getLogger('BindingJsonRpc')
Line 36: 
Line 37:     def __init__(self, bridge, subs, timeout, scheduler, cif):
Line 38:         self._executor = executor.Executor(name="jsonrpcex",
> Do we need the "ex" suffix? The executor worker threads will be named jsonr

no good reason, fixing.
Line 39:                                            workers_count=_THREADS,
Line 40:                                            max_tasks=_TASKS,
Line 41:                                            scheduler=scheduler)
Line 42:         self._bridge = bridge

gerrit-hooks has posted comments on this change.

Change subject: jsonrpc: shorten executor thread system names
......................................................................

Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])

Francesco Romani has posted comments on this change.

Change subject: jsonrpc: shorten executor thread system names
......................................................................

Patch Set 7: Verified+1

Verified running patched vdsm and checking the thread names with 'htop'
Tested flows:
- vm startup/shutdown
- migratin inbound/outbound

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: jsonrpc: shorten executor thread system names
......................................................................

Patch Set 7: Code-Review+1

Irit Goihman has posted comments on this change.

Change subject: jsonrpc: shorten executor thread system names
......................................................................

Patch Set 7: Code-Review+1

gerrit-hooks has posted comments on this change.

Change subject: jsonrpc: shorten executor thread system names
......................................................................

Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])

gerrit-hooks has posted comments on this change.

Change subject: jsonrpc: shorten executor thread system names
......................................................................

Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])

[Piotr Kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpc: shorten executor thread system names
......................................................................

Patch Set 9: Code-Review+2

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: jsonrpc: shorten executor thread system names
......................................................................

jsonrpc: shorten executor thread system names

We shorten the basename of the jsonrpc executor,
because the system has a hard limit of 15 ASCII
character per thread name.

The new name is less expressive, but leaves room
for the worker ID, which is an overall usability
improvement.

Before, it looked like

jsonrpc.Executo

now it looks like

jsonrpc/0

Change-Id: Ibefc7d2c60d7b5d23739b129088f8e7f80514540
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/61978
Reviewed-by: Nir Soffer 
Reviewed-by: Irit Goihman 
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski 
---
M lib/vdsm/rpc/bindingjsonrpc.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Nir Soffer: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Irit Goihman: Looks good to me, but someone else must approve
  Francesco Romani: Verified

gerrit-hooks has posted comments on this change.

Change subject: jsonrpc: shorten executor thread system names
......................................................................

Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.