Milan Zamazal has posted comments on this change.
Change subject: API: modernize VM methods
......................................................................
Patch Set 19: Code-Review+1
(2 comments)
https://gerrit.ovirt.org/#/c/61475/18/vdsm/API.py
File vdsm/API.py:
Line 125:
Line 126: @property
Line 127: def vm(self):
Line 128: v = self._cif.vmContainer.get(self._UUID)
Line 129: if not v:
Yes, it could be
It's a good practice to use the idiomatic check for None (is / is not) whether the object can be false or not.
Line 130: raise exception.NoSuchVM()
Line 131: return v
Line 132:
Line 133: @api.method
https://gerrit.ovirt.org/#/c/61475/19/vdsm/API.py
File vdsm/API.py:
PS19, Line 338: to run
running ?
--
To view, visit
https://gerrit.ovirt.org/61475
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2e238fc632df97b63f7bb2a6293fe1c392a842
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
fromani@redhat.com
Gerrit-Reviewer: Arik Hadas
ahadas@redhat.com
Gerrit-Reviewer: Francesco Romani
fromani@redhat.com
Gerrit-Reviewer: Irit Goihman
igoihman@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
mpolednik@redhat.com
Gerrit-Reviewer: Michal Skrivanek
michal.skrivanek@redhat.com
Gerrit-Reviewer: Milan Zamazal
mzamazal@redhat.com
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Piotr Kliczewski
piotr.kliczewski@gmail.com
Gerrit-Reviewer: gerrit-hooks
automation@ovirt.org
Gerrit-HasComments: Yes