Federico Simoncelli has posted comments on this change.
Change subject: BZ#807642 Use Securable as base class
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/storage/securable.py
Line 60: if not (self._isSafe() or override):
Even if fixed, someone can call self._setUnsafe while f() is running,
and nothing in Securable protects f from doing harm.
The idea here is to be consistent in the positive flow. The self._setUnsafe()
shouldn't complete until f() completed. Nothing in securable protects from f(), that
is correct, but we shouldn't advertise that we stopped the spm while we still have f()
running. That is why we would need to queue stopSpm behind the secured calls.
I agree on postponing this fix.
--
To view, visit
http://gerrit.ovirt.org/3198
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2309e2cfc0291309023238ed91527884ec879d64
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>