Zhou Zheng Sheng has uploaded a new change for review.
Change subject: functional test: boot VM with network interface device ......................................................................
functional test: boot VM with network interface device
Change-Id: I18c350074ce2b9712c468899075e5e2e22ee2550 Signed-off-by: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com --- M tests/functional/xmlrpcTests.py 1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/15633/1
diff --git a/tests/functional/xmlrpcTests.py b/tests/functional/xmlrpcTests.py index 3e5244e..9189239 100644 --- a/tests/functional/xmlrpcTests.py +++ b/tests/functional/xmlrpcTests.py @@ -171,8 +171,15 @@
@skipNoKVM def testStartSmallVM(self): + pciAddress = {'slot': '0x03', 'bus': '0x00', 'domain': '0x0000', + 'function': '0x0', 'type': 'pci'} + interfaceDev = {'nicModel': 'virtio', 'macAddr': '52:54:00:59:F5:3F', + 'network': '', 'address': pciAddress, + 'device': 'bridge', 'type': 'interface', + 'linkActive': True, 'filter': 'no-mac-spoofing'} customization = {'vmId': '77777777-ffff-3333-bbbb-222222222222', - 'vmName': 'vdsm_testSmallVM'} + 'vmName': 'vdsm_testSmallVM', + 'devices': [interfaceDev]}
self._runVMKernelBootTemplate(customization)
Zhou Zheng Sheng has posted comments on this change.
Change subject: functional test: boot VM with network interface device ......................................................................
Patch Set 1: Verified
Test on Fedora17 and RHEL6.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: functional test: boot VM with network interface device ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2764/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1952/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2838/ : SUCCESS
Giuseppe Vallarelli has posted comments on this change.
Change subject: functional test: boot VM with network interface device ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
-1 Asking a question.
.................................................... File tests/functional/xmlrpcTests.py Line 172: @skipNoKVM Line 173: def testStartSmallVM(self): Line 174: pciAddress = {'slot': '0x03', 'bus': '0x00', 'domain': '0x0000', Line 175: 'function': '0x0', 'type': 'pci'} Line 176: interfaceDev = {'nicModel': 'virtio', 'macAddr': '52:54:00:59:F5:3F', Zhou does this test rely on actual values, what happens if you change for example macAddr? Line 177: 'network': '', 'address': pciAddress, Line 178: 'device': 'bridge', 'type': 'interface', Line 179: 'linkActive': True, 'filter': 'no-mac-spoofing'} Line 180: customization = {'vmId': '77777777-ffff-3333-bbbb-222222222222',
Zhou Zheng Sheng has posted comments on this change.
Change subject: functional test: boot VM with network interface device ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File tests/functional/xmlrpcTests.py Line 172: @skipNoKVM Line 173: def testStartSmallVM(self): Line 174: pciAddress = {'slot': '0x03', 'bus': '0x00', 'domain': '0x0000', Line 175: 'function': '0x0', 'type': 'pci'} Line 176: interfaceDev = {'nicModel': 'virtio', 'macAddr': '52:54:00:59:F5:3F', Thanks Giuseppe, this value can be anything that looks like a real MAC address. It's better to be different from any existing MAC addresses. If there were any conflicts, it is still OK, because the VM just lives for 60 seconds and the chance to have conflicts is very small. Line 177: 'network': '', 'address': pciAddress, Line 178: 'device': 'bridge', 'type': 'interface', Line 179: 'linkActive': True, 'filter': 'no-mac-spoofing'} Line 180: customization = {'vmId': '77777777-ffff-3333-bbbb-222222222222',
Giuseppe Vallarelli has posted comments on this change.
Change subject: functional test: boot VM with network interface device ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
.................................................... File tests/functional/xmlrpcTests.py Line 172: @skipNoKVM Line 173: def testStartSmallVM(self): Line 174: pciAddress = {'slot': '0x03', 'bus': '0x00', 'domain': '0x0000', Line 175: 'function': '0x0', 'type': 'pci'} Line 176: interfaceDev = {'nicModel': 'virtio', 'macAddr': '52:54:00:59:F5:3F', Ok not a big deal, it would be better if we are not conflicting for sure with any underlying device, my understanding is that you're only applying a customization and verifying that no failures happen. Line 177: 'network': '', 'address': pciAddress, Line 178: 'device': 'bridge', 'type': 'interface', Line 179: 'linkActive': True, 'filter': 'no-mac-spoofing'} Line 180: customization = {'vmId': '77777777-ffff-3333-bbbb-222222222222',
Dan Kenigsberg has posted comments on this change.
Change subject: functional test: boot VM with network interface device ......................................................................
Patch Set 1: Looks good to me, approved
Dan Kenigsberg has submitted this change and it was merged.
Change subject: functional test: boot VM with network interface device ......................................................................
functional test: boot VM with network interface device
Change-Id: I18c350074ce2b9712c468899075e5e2e22ee2550 Signed-off-by: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Reviewed-on: http://gerrit.ovirt.org/15633 Reviewed-by: Giuseppe Vallarelli gvallare@redhat.com Reviewed-by: Dan Kenigsberg danken@redhat.com --- M tests/functional/xmlrpcTests.py 1 file changed, 8 insertions(+), 1 deletion(-)
Approvals: Giuseppe Vallarelli: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Zhou Zheng Sheng: Verified
vdsm-patches@lists.fedorahosted.org